Add MeshExtension API to extensions#3650
Merged
istio-testing merged 9 commits intoistio:masterfrom Mar 25, 2026
Merged
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
|
😊 Welcome @liamawhite! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XL
3 tasks
- Move top-level TrafficSelector to extension_filter.proto - Keep WasmPlugin.TrafficSelector nested for backward compat - Remove targetRef from ExtensionFilter - Add release notes
istio-policy-bot
added
the
lifecycle/stale
liamawhite
commented
Mar 17, 2026
istio-policy-bot
removed
the
lifecycle/stale
liamawhite
changed the title
liamawhite
removed
the
do-not-merge/work-in-progress
keithmattix
reviewed
Mar 17, 2026
…mment - Renumber ExtensionFilter fields to be contiguous (targetRefs=2, phase=3, priority=4, match=5) - Wrap wasm/lua in oneof filter_config for type-safe mutual exclusion - Clarify priority tiebreaker ordering (creationTimestamp, then name/namespace) - Regenerate pb.go, pb.html, and CRD YAML
keithmattix
approved these changes
Mar 20, 2026
Contributor
ramaraochavali
left a comment
ramaraochavali
left a comment
There was a problem hiding this comment.
LGTM. Couple of naming questions for discussion
- Rename extension_filter.proto to mesh_extension.proto - Update all references, comments, cue-gen tags, and doc annotations - Update CRD kind from ExtensionFilter to MeshExtension - Update release note - Regenerate all artifacts
liamawhite
changed the title
Contributor
|
Ok, I know this is really bikeshedding.....but I don't really like MeshExtension, specifically because it's useable for gateways as well. What about trafficextension? |
Contributor
I am fine with that |
- Rename mesh_extension.proto to traffic_extension.proto - Update all references, comments, cue-gen tags, and doc annotations - Update CRD kind from MeshExtension to TrafficExtension - Rename release note file to add-traffic-extension.yaml - Regenerate all artifacts
- Add ExecutionPhase as the canonical phase enum in traffic_extension.proto - TrafficExtension.phase now uses ExecutionPhase - Annotate PluginPhase in wasm.proto as kept for backward compat only - Regenerate all artifacts
Member
Author
|
Ok I think we should be good to go? |
Contributor
|
@ramaraochavali one last review from you should do it! |
ramaraochavali
approved these changes
Mar 25, 2026
Contributor
ramaraochavali
left a comment
ramaraochavali
left a comment
There was a problem hiding this comment.
Thank you. This is great
liamawhite
added a commit
to liamawhite/istio
that referenced
this pull request
Mar 25, 2026
The API PR (istio/api#3650) has been merged. This updates the codebase to use the real upstream istio.io/api and istio.io/client-go modules, removing the replace directives pointing to the liamawhite forks. Key changes from the merged API: - ExtensionFilter renamed to TrafficExtension - PluginPhase renamed to ExecutionPhase (AUTHN/AUTHZ/STATS constants updated) - Wasm/Lua fields moved into a FilterConfig oneof, requiring use of TrafficExtension_Wasm and TrafficExtension_Lua wrapper types - TrafficExtension only has TargetRefs (plural), no singular TargetRef Update all code, generated schema files, and tests accordingly.
liamawhite
added a commit
to liamawhite/istio
that referenced
this pull request
Mar 25, 2026
The API PR (istio/api#3650) has been merged. This updates the codebase to use the real upstream istio.io/api and istio.io/client-go modules, removing the replace directives pointing to the liamawhite forks. Key changes from the merged API: - ExtensionFilter renamed to TrafficExtension - PluginPhase renamed to ExecutionPhase (AUTHN/AUTHZ/STATS constants updated) - Wasm/Lua fields moved into a FilterConfig oneof, requiring use of TrafficExtension_Wasm and TrafficExtension_Lua wrapper types - TrafficExtension only has TargetRefs (plural), no singular TargetRef Update all code, generated schema files, and tests accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Adds the
MeshExtensionAPI (formerlyExtensionFilter) to the extensions package, providing a unified mechanism for configuring WebAssembly and Lua filters with consistent targeting and configuration patterns. This adds native support for Lua filters as described in the following design doc.Related implementation PR is here.