Skip to content

add statsCompression field to MeshConfig API, deprecating per pod annotation#3628

Merged
istio-testing merged 1 commit intoistio:masterfrom
frittentheke:statsCompressionPerDefault
Jan 21, 2026
Merged

add statsCompression field to MeshConfig API, deprecating per pod annotation#3628
istio-testing merged 1 commit intoistio:masterfrom
frittentheke:statsCompressionPerDefault

Conversation

@frittentheke
Copy link
Contributor

@frittentheke frittentheke commented Jan 10, 2026 •
edited
Loading

@frittentheke frittentheke requested a review from a team as a code owner January 10, 2026 17:20
@istio-policy-bot
Copy link

istio-policy-bot commented Jan 10, 2026

😊 Welcome @frittentheke! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jan 10, 2026
@istio-testing
Copy link
Collaborator

istio-testing commented Jan 10, 2026

Hi @frittentheke. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@frittentheke frittentheke mentioned this pull request Jan 12, 2026
Merged
@frittentheke
add statsCompression field to MeshConfig API, deprecating per pod ann…
71f91b7 
…otation (#48051)

* if set to true Envoy applies HTTP compression for metrics / stats via brotli,
zstd or gzip if client sends appropriate `Accept-Encoding` header.

* deprecate `sidecar.istio.io/statsCompression` annotation

xref: istio/istio#48051
Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
@frittentheke frittentheke force-pushed the statsCompressionPerDefault branch from ca4bef3 to 71f91b7 Compare January 19, 2026 15:34
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2026
@frittentheke frittentheke changed the title deprecate annotation for statsCompression add statsCompression field to MeshConfig API, deprecating per pod annotation Jan 19, 2026
zirain
zirain approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-policy-bot
Copy link

istio-policy-bot commented Jan 20, 2026

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@frittentheke
Copy link
Contributor Author

frittentheke commented Jan 20, 2026

LGTM

@zirain could you run the tests then?

Also I have PR istio/istio#58717 which contains the changes on the Istio side.
Please kindly take a look at that one as well.

@keithmattix
Copy link
Contributor

keithmattix commented Jan 20, 2026

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 20, 2026
keithmattix
keithmattix approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right for a 1.30 target. If you're wanting to get this new field into the upcoming 1.29 release, then I don't think we can deprecate.

Adding a hold for further TOC weigh-in/contributor response

@keithmattix keithmattix added the do-not-merge/hold Block automatic merging of a PR. label Jan 20, 2026
@frittentheke
Copy link
Contributor Author

frittentheke commented Jan 20, 2026 •
edited
Loading

This looks right for a 1.30 target. If you're wanting to get this new field into the upcoming 1.29 release, then I don't think we can deprecate.

  1. Thanks @keithmattix !
  2. Yes, I deprecate the sidecar annotation in this PR, this is from an alpha state mind you.
  3. The deprecation was in favor of the now mesh-wide configurability,
    something I believe most Istio mesh admins likely appreciate (looking at you @larhauga)
  4. If one still needs this "per pod" there always is the way via https://istio.io/latest/docs/reference/config/annotations/#ProxyConfig

Should you agree this can be done in one swoop there might need to be a note in the release notes / upgrade nodes in any case.

@keithmattix keithmattix removed the do-not-merge/hold Block automatic merging of a PR. label Jan 21, 2026
@istio-testing istio-testing merged commit 6caf945 into istio:master Jan 21, 2026
5 checks passed
@keithmattix keithmattix added the cherrypick/release-1.29 Set this label on a PR to auto-merge it to the release-1.29 branch label Jan 21, 2026
@keithmattix
Copy link
Contributor

keithmattix commented Jan 21, 2026

/cherry-pick release-1.29

@istio-testing
Copy link
Collaborator

istio-testing commented Jan 21, 2026

@keithmattix: new pull request created: #3640

Details

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing mentioned this pull request Jan 21, 2026
Merged
@frittentheke frittentheke mentioned this pull request Jan 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithmattix keithmattix keithmattix approved these changes

@zirain zirain zirain approved these changes

Assignees

No one assigned

Labels

cherrypick/release-1.29 Set this label on a PR to auto-merge it to the release-1.29 branch ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

followup on prom stats compression

5 participants

@frittentheke @istio-policy-bot @istio-testing @keithmattix @zirain