Remove dead code and stale Python 2 leftovers (with the help of Claude Fable) - #947
Conversation
Carreau
commented
Jul 13, 2026
- ClassTypes tuple in traitlets.py, a Python 2/3 compat constant never used and not exported
- execfile() shim in config/loader.py, shadowing the removed Python 2 builtin, never called
- Config._merge in config/loader.py, a deprecated private alias for Config.merge that was never called and never warned
All verified unreferenced across the package, tests, and docs: - ClassTypes tuple in traitlets.py, a Python 2/3 compat constant never used and not exported - execfile() shim in config/loader.py, shadowing the removed Python 2 builtin, never called - Config._merge in config/loader.py, a deprecated private alias for Config.merge that was never called and never warned
@Carreau, unfortunately this change broke both Spyder and Spyder-kernels. Could you release 5.16.1 reverting it? That would give us time to address it in versions 6.1.7/3.1.6 of those packages, to be released at the end of August. By the way, I don't remember why we're using |
|
just I'll do that on monday. |
|
Please feel free to send a PR next time (And see #963 for And |
I think so. I mean, that's what I saw in our failing tests. But I'll check more thoroughly during the weekend.
Thanks!
Will do. I just wanted to see first if you were ok with the idea.
As I said, I don't recall why we use |
|
We should also start to publish nightly of traitlets maybe. |