Merged
Conversation
Contributor
Author
|
VRRP integration tests revealed that cRPD doesn't work with EOS or FRR due to cb2359c. Peering with IOL also fails: packet captures from IOL show the same checksum errors. I cannot find the same knob in cRPD and CRPD<->CRPD works. |
Owner
|
Thank you! A few minor details:
|
ipspace
reviewed
Feb 24, 2026
| @@ -1,12 +1,13 @@ | |||
| {% if vrfs is defined %} | |||
Owner
There was a problem hiding this comment.
Now I know why the Junos MPLS/VPN RR tests were failing ;) Thank you!
* Modified 'gateway' documentation as cRPD does not support anycast gateway * Use a separate cRPD template for gateway configuration to avoid cluttering the Junos template with 'unit 0' tricks, particularly since cRPD only supports VRRP and not anycast gateway * Optimize the /etc/hosts template * Add 'show command' group var to enable 'netlab connect --show' functionality * Make Ruff happy ;)
ipspace
added a commit
that referenced
this pull request
Feb 24, 2026
ipspace
approved these changes
Feb 24, 2026
Owner
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
Did a bit of cleanup and added device quirks.
New integration tests pass, we still have to deal with unnumbered interface configuration and VRF loopbacks. Will open issues for those two.
If you're OK with my changes we're good to merge ;)
Contributor
Author
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added and fixed a few things:
vrfsdata. Added check.