Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
thetaPC
approved these changes
Aug 11, 2026
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with minor suggestions
| return; | ||
| } | ||
|
|
||
| const prefix = `[Ionic Debug]: [${namespace}] - ${event}`; |
Contributor
There was a problem hiding this comment.
I really like this! It's easy to spot that it's coming from Ionic now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently,
StackManagerin@ionic/react-routerwrites six some console logs that most users do not use. They're still useful for debugging issues with routing though if they come up again, so we left them in. However, every user using the stack manger would get these logs regardless of if they're debugging something or not.What is the new behavior?
The logs now go through a gated logger and stay silent unless the app asks for them with
logLevel: 'DEBUG', either throughsetupIonicReact({ logLevel: LogLevel.DEBUG })or?ionic:logLevel=DEBUGin the URL. We reuse Ionic's existinglogLevelconfig rather than adding a second switch, soDEBUGis a new member of theLogLevelenum andprintIonWarning/printIonErrornow compare ranks instead of testing array membership.Does this introduce a breaking change?
Other information
Initially I thought all of these logs had some value, but on review I found some of them did not and caused extra overhead for no reason. During this PR, I cleaned up some logs that no longer had actual purpose, but left ones that I think will provide future value