feat(gallery): add new required gallery-item component for child items#31195
Draft
brandyscarney wants to merge 14 commits into
Draft
feat(gallery): add new required gallery-item component for child items#31195brandyscarney wants to merge 14 commits into
brandyscarney wants to merge 14 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
commented
Jun 5, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue number: internal
What is the current behavior?
The Gallery component queries all direct children and uses them to build both the uniform and masonry layouts. This causes issues when a wrapper element exists between the gallery and the gallery items. For example:
In this scenario, the gallery treats the wrapper as a single item and does not correctly lay out the images contained within it.
What is the new behavior?
Several approaches were considered:
ion-gallery-itemcomponent that encapsulates all item-related styling and can contain arbitrary content (img, div, etc.).We ultimately chose option 3 and introduced a new
ion-gallery-itemcomponent. Theion-gallerycomponent now queries forion-gallery-itemelements instead of relying on direct children.As such, this PR does the following:
ion-gallery-itemcomponent.ion-galleryto query forion-gallery-itemelements.ion-gallery-item.Does this introduce a breaking change?
Other information
Dev build:
8.8.9-dev.11780690416.19d0d667Previews: