docs(@capacitor/push-notifications): Add common issue about iOS simulator support and device tokens#2026
Closed
matthewbal wants to merge 3 commits intoionic-team:mainfrom
Closed
docs(@capacitor/push-notifications): Add common issue about iOS simulator support and device tokens#2026matthewbal wants to merge 3 commits intoionic-team:mainfrom
matthewbal wants to merge 3 commits intoionic-team:mainfrom
Conversation
Added a section to common issues, reminding users that on an iOS simulator the register event will fail silently.
matthewbal
changed the title
Added caveat that it works with macOS 13+ and xcode 14+
IT-MikeS
changed the title
Member
|
@matthewbal - Please update your PR if you would like to get it reviewed. We appreciate your contribution! |
Author
|
@eric-horodyski Sorry this one slipped my mind - I can't figure out what I should update in this PR, could you please give me some guidance on that? I haven't done a lot of open source contributions before so I'm new to the process. |
Member
|
Capacitor 8 requires Xcode 26, so I see no value in adding this note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a section to common issues, reminding users that on an iOS simulator the register event will fail silently.
Closes #2025