va: use secure_getenv instead of getenv in va_x11.c#876
Open
XinfengZhang wants to merge 1 commit intointel:masterfrom
Open
va: use secure_getenv instead of getenv in va_x11.c#876XinfengZhang wants to merge 1 commit intointel:masterfrom
XinfengZhang wants to merge 1 commit intointel:masterfrom
Conversation
XinfengZhang
force-pushed
the
getenv
branch
2 times, most recently
from
3bca966 to
d697564
Compare
Move the secure_getenv fallback from va.c to va_internal.h so it is available to all internal callers, and replace the plain getenv call in va_x11.c with secure_getenv. On Windows, secure_getenv is defined as getenv since there is no setuid/setgid concept. This prevents environment variables from influencing behavior in setuid/setgid programs on Linux. Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
XinfengZhang
force-pushed
the
getenv
branch
2 times, most recently
from
bd07123 to
7eb117a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the secure_getenv fallback from va.c to va_internal.h so it is available to all internal callers, and replace the plain getenv call in va_x11.c with secure_getenv. This prevents environment variables from influencing behavior in setuid/setgid programs.