test: switched aws sdk tests to localstack by abhilash-sivan · Pull Request #2708 · instana/nodejs

abhilash-sivan · 2026-08-11T05:11:23Z

refs https://jsw.ibm.com/browse/INSTA-108647

added localstack support for aws tests
to run against real AWS instead of LocalStack, log in and unset set RUN_AWS

test result: https://ibm.box.com/s/c4kttm6qsxcb2sizhev1lkz28giw4w6j

abhilash-sivan · 2026-08-11T11:22:39Z

 const availableCtx = [null, '{"Custom": {"awesome_company": "Instana"}}', '{"Custom": "Something"}'];
 const requestMethods = ['Callback', 'Promise'];
-const availableOperations = ['invoke', 'invokeAsync'];
+const availableOperations = ['invoke'];


self note: check invokeAsync

https://docs.localstack.cloud/aws/services/lambda/#api-coverage

invokeAsync is not supported by localstack

We removed invokeAsync completely? This is really concerning.

Added back for actual AWS test

abhilash-sivan · 2026-08-13T08:11:03Z

 const availableCommands = {
  PublishCommand: {
    Message: 'STRING_VALUE',
-    TargetArn: 'STRING_VALUE',


in availableCommands, PublishCommand includes both TargetArn and TopicArn (the TopicArn is added in the loop at line 157). AWS SNS won't accept both simultaneously.

It was working previously because the actual test never ran against AWS, only LS

kirrg001 · 2026-08-13T09:11:30Z

-        AVAILABLE_SIDECARS=""
-        SIDECAR_COUNTS=""
+        AVAILABLE_SIDECARS="localstack"
+        SIDECAR_COUNTS="localstack=1"


Did you manually edit these?

Yes, do we have a script to add sidecars? I though no

🤔 But these are test groups files. These are generated not?

.tekton/tasks/test-groups/aws-lambda-split-2-task.yaml

The 'generate test files' script does not make any changes. So the addition is correct right?

The sidecars are automatically added to the generated test files.
No manual edits in the generated files

Oky. I was on the wrong branch. The 'generate test files' does make changes, i will update

kirrg001 · 2026-08-13T10:53:08Z

  'test:ci:autoprofile': {},
  'test:ci:aws-fargate': {},
-  'test:ci:aws-lambda': { split: 5 },
+  'test:ci:aws-lambda': { split: 5, sidecars: ['localstack'] },


I thought aws lambda pkg does not run against AWS? Why do we have to change that

We have 2 tests SSM and KMS client tests, running against AWS in this package

#1649

Its all packages except aws lambda. I remembered wrong.

aryamohanan · 2026-08-14T07:03:08Z

 const availableCtx = [null, '{"Custom": {"awesome_company": "Instana"}}', '{"Custom": "Something"}'];
 const requestMethods = ['Callback', 'Promise'];
-const availableOperations = ['invoke', 'invokeAsync'];
+const availableOperations = process.env.RUN_AWS ? ['invoke', 'invokeAsync'] : ['invoke'];


I think we should add a proper comment here explaining that invokeAsync is currently not supported by LS. We could also consider requesting this feature from the LocalStack team, as they may add support for it in the future.

aryamohanan · 2026-08-14T07:12:18Z

  this.headers[this.getUserAgentHeaderName()] = [this._userAgent];
 };

+function getLocalstackEndpoint() {


We’re repeating the same functions in multiple places. Could we move them into a generic test utility file and reuse them across the tests instead? This would help avoid duplication and make them easier to maintain.

I already tried it. I ran into an issue while copying the files to the test directory from a common location.

Also, there are already utility files in multiple AWS tests, so I think we can keep the functions for now. It also gives us the flexibility to configure each test differently if needed.

I don't think it's worth spending more time optimising this right now

We define getLocalstackEndpoint() in 15 different places. I think it would be better to move this, along with getClientConfig(), into a common test utility file and reuse them across the tests. We already have a common utilities file for this, so we can avoid duplicating these functions.

abhilash-sivan changed the title ~~test: switched aws dynamodb test to localstack~~ test: switched aws sdk tests to localstack Aug 11, 2026

abhilash-sivan commented Aug 11, 2026

View reviewed changes

abhilash-sivan force-pushed the chore-aws-sdk branch from 301af84 to 0143312 Compare August 12, 2026 10:00

abhilash-sivan marked this pull request as ready for review August 12, 2026 10:25

abhilash-sivan requested a review from a team as a code owner August 12, 2026 10:25

aryamohanan reviewed Aug 12, 2026

View reviewed changes

Comment thread packages/aws-lambda/src/ssm.js Outdated

aryamohanan reviewed Aug 12, 2026

View reviewed changes

Comment thread packages/collector/test/integration/currencies/cloud/@aws-sdk/client-dynamodb/app.js

abhilash-sivan commented Aug 12, 2026

View reviewed changes

Comment thread packages/aws-lambda/test/integration_test/test_definition.js Outdated

kirrg001 reviewed Aug 12, 2026

View reviewed changes

Comment thread .tekton/templates/test-task.yaml.template Outdated

abhilash-sivan commented Aug 13, 2026

View reviewed changes

kirrg001 reviewed Aug 13, 2026

View reviewed changes

aryamohanan reviewed Aug 14, 2026

View reviewed changes

Comment thread packages/collector/test/integration/currencies/cloud/aws-sdk/lambda/app.mjs Outdated

aryamohanan reviewed Aug 14, 2026

View reviewed changes

abhilash-sivan added 15 commits August 14, 2026 13:21

test: switched aws dynamodb test to localstack

7a12b6e

test: switch kinesis test to use localstack

894de49

test: aws s3

6d6a643

chore: apply TEST_NAME_FILTER as mocha --grep when no named file matches

a29aa1c

chore: sns and sqs

f07a362

chore: lambda

935cf29

chore: tekton

95ed503

chore: ssm and kms

c24c05c

chore: tekton

9911354

chore: update task

855cd2e

chore: rebase

9504d6a

chore: add fallback for kinesis

e74fe57

chore: comments

543ba14

chore: ssm

8395da5

chore: initenv

b659910

abhilash-sivan added 19 commits August 14, 2026 13:21

chore: ssm fix

4f691c2

chore: use RUN_AWS

b356303

chore: update tekton

7225b07

chore: invokeAsync fix

eac64fd

chore: dynamodb fix

e0a62a7

chore: tekton

d84c0c7

chore: test

e793a76

chore: lambda

99cf420

chore: sns

0f8730a

chore: sqs

2f406e7

chore: v2 sns sqs

0bc8120

chore: typo

35ca68d

chore: combined prod

56602e2

chore: sqs v3

18d3479

chore: aws sns v3

0826d25

chore: cleanup commets

62d1a3c

chore: sidecar

728d905

chore: update

f588ca4

chore: cleanup

24ed279

abhilash-sivan force-pushed the chore-aws-sdk branch from 0dfc5d0 to 24ed279 Compare August 14, 2026 07:51

abhilash-sivan added 3 commits August 14, 2026 13:35

chore: export

155279e

chore: common util for v3

7fbcd5a

chore: aws util v2

7217d92

abhilash-sivan force-pushed the chore-aws-sdk branch from ea4106c to 155279e Compare August 14, 2026 12:38

Uh oh!

Conversation

abhilash-sivan commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abhilash-sivan commented Aug 11, 2026 •

edited

Loading