Skip to content

fix: add --ignore-engines to Cypress Dockerfile#7177

Open
blegesse-w wants to merge 1 commit into
masterfrom
fix/cypress-dockerfile-ignore-engines
Open

fix: add --ignore-engines to Cypress Dockerfile#7177
blegesse-w wants to merge 1 commit into
masterfrom
fix/cypress-dockerfile-ignore-engines

Conversation

@blegesse-w
Copy link
Copy Markdown
Member

@blegesse-w blegesse-w commented May 26, 2026

Summary

  • The cypress-slim:9.5.2-included base image runs Node 18.12.1, but @peculiar/x509@1.14.3 (a transitive dep) now requires Node >= 20
  • Since the Dockerfile does a fresh yarn add with no lockfile, it picks up the latest version and fails the engine check
  • This is breaking build-e2e-image in monitor-ci across all branches
  • Adds --ignore-engines to unblock until the cypress-slim base image is updated to Node 20+

Test plan

  • monitor-ci build-e2e-image job passes

🤖 Generated with Claude Code

The cypress-slim base image uses Node 18.12.1, but @peculiar/x509@1.14.3
(a transitive dep) now requires Node >= 20. Since the Dockerfile does a
fresh yarn add with no lockfile, it picks up the latest version and fails
the engine check. This unblocks monitor-ci until the base image is updated.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@blegesse-w
Copy link
Copy Markdown
Member Author

hey @jdstrand, while working on the webpack-dev-server bump (#7176), i found that the monitor-ci build-e2e-image failure is actually unrelated to that PR. the cypress-slim base image is on Node 18, and @peculiar/x509 (a transitive dep) just released a version requiring Node 20+. the Dockerfile does a fresh yarn add with no lockfile so it picks up the latest and fails the engine check. and this was breaking all branches, not just mine. put up this pr #7177 to add --ignore-engines to the yarn add. it only affects the cypress test container, not production, and all checks pass. once that merges, the webpack-dev-server PR should go green too.

@blegesse-w blegesse-w added this pull request to the merge queue May 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 26, 2026
@blegesse-w blegesse-w added this pull request to the merge queue May 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 26, 2026
@jdstrand jdstrand added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@jdstrand jdstrand added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@jdstrand jdstrand added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@jdstrand jdstrand added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@jdstrand
Copy link
Copy Markdown
Contributor

@blegesse-w - I see you tried to merge this, so I tried a few more times, but it keeps getting kicked back. I have not looked into why....

@jdstrand jdstrand added this pull request to the merge queue May 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 28, 2026
@jdstrand jdstrand added this pull request to the merge queue May 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 29, 2026
@blegesse-w
Copy link
Copy Markdown
Member Author

@blegesse-w - I see you tried to merge this, so I tried a few more times, but it keeps getting kicked back. I have not looked into why....

thanks for trying, Jamie. I don't think the failure is related to this PR. it's a flaky integration test failing with assert_equal(): [Reason: dbase over null (nil)], which looks like the test environment's database isn't coming up properly? idk. I will look into the monitor-ci test infra

@jdstrand jdstrand added this pull request to the merge queue May 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 29, 2026
@jdstrand jdstrand added this pull request to the merge queue Jun 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@jdstrand jdstrand added this pull request to the merge queue Jun 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@blegesse-w
Copy link
Copy Markdown
Member Author

@jdstrand hey jamie, i traced the monitor-ci failure all the way down. the pipeline gets created (22910) but the setup workflow fails at the "Generate .circleci/config-dynamic.json" step. the error is a curl 401 Unauthorized during config generation. looks like a credential used in the monitor-ci dynamic config setup has expired. this will def block all PRs from merging, not just mine. I will check the monitor-ci project's environment variables / contexts in CircleCI. the specific error output is: filterTestsDisabledInConfigCat: skipping as UIE2ESkipConfigCat is set curl: (22) The requested URL returned error: 401 Exited with code exit status 22

@blegesse-w blegesse-w added this pull request to the merge queue Jun 1, 2026
@blegesse-w
Copy link
Copy Markdown
Member Author

update on the monitor-ci blocker: the UI_CI_TOKEN (github PAT on the team-ui-bot-influx account) had expired. i rotated it with a 90-day expiration and updated it in monitor-ci's circleci settings.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@blegesse-w blegesse-w added this pull request to the merge queue Jun 1, 2026
@blegesse-w
Copy link
Copy Markdown
Member Author

blegesse-w commented Jun 1, 2026

quay.io is having a major outage 😭 pushes are disabled registry-wide. nothing we can do until they resolve it. i'll re-add to the merge queue once quay is back up.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@jdstrand jdstrand added this pull request to the merge queue Jun 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@blegesse-w blegesse-w added this pull request to the merge queue Jun 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants