Conversation
Some header files had to be rearranged. Note: Compat.h is meant to be included automatically by INETDefs.h so it should not be included manually in any files (except Compat.cc)
The "displayTime=..." line produced simtime overflow error, because indexStart was bogus a huge positive integer. It was computed as: auto indexStart = (int)... * durations.size(); which is signed * unsigned multiplication, whose result was signed on Linux, and unsigned on Windows. Workaround: factor out durations.size() as int numDurations, to eliminate mixed-sign multiplications in the code. Also, make indexStart / indexEnd explicit signed int.
fix for 'all: optimize cancelEvent(x);scheduleAt/After(t, x) calls with rescheduleAt/After(x)' 88c582c
Detected with CHUNK_CHECK_IMPLEMENTATION_ENABLED.
Required for g726 codec in libavcodec: 60.3.100. Tested with libavcodec: 59.37.100, too.
…ative values. Previously if the rate of incoming traffic was higher than the rate of outgoing traffic, the number of tokens statistic could be negative which doesn't really make sense. The number of tokens statistics is created by emitting values into the future such that a sawtooth pattern is created. The actual behavior of the ATS is not influenced by this change because the number of tokens is just a derived statistic for a virtual token bucket.
…roughput. Previously the filter emitted 0 but now it either emits nan or inf depending on what is the value of totalLength.
Other non GDB related inet and omnetpp python packages are not imported anymore.
…ed when there are no rules. Also, link weights are reset after using the topology.
…ulations which are not present in the CSV files.
…se omnetpp 6.1 checks it strictly.
…ding whether it's available or not. This allows running the sanitizer tests without OSG support, for example.
…y leaks detected by sanitizer tests.
This simulaion fails with a 'Cannot schedule message to the past' error.
…nning sanitizer tests.
…he opp_featuretool and then runs all tests.
This doesn't belong here.
…fix of tests/packet.
…ion configs. The release executable is called to determine the number of runs.
…files are up to date.
…unning opp tests.
The FlowMeasurementRecorder had confusing parameter names that made it unclear how flow termination and measurement types interact: - Renamed 'measure' to 'endMeasurementTypes' for clarity - Added comprehensive documentation explaining: * Flow Termination Parameters (flowName, endMeasurement) - which flows to terminate * Measurement Type Parameters (endMeasurementTypes) - which measurement types to end - Added backward compatibility: old 'measure' parameter still works with deprecation warning Key clarification: All measurements are always recorded (emitted as signals), but only selected types are actually ended (removed from packet tags) when the flow terminates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the confusing parameter names in FlowMeasurementRecorder reported in #1089.
Problem
The
measureparameter name suggested what gets measured, but it actually controls which measurement types get ended when a flow terminates. This was confusing because:flowNameandendMeasurementcontrol flow terminationmeasurecontrolled measurement types (unrelated to what gets recorded)Solution
measure→endMeasurementTypesfor claritymeasureparameter still works but logs a deprecation warningFiles Changed
src/inet/flowmeasurement/FlowMeasurementRecorder.ned- Parameter rename + documentationsrc/inet/flowmeasurement/FlowMeasurementRecorder.cc- Backward compatibility logicBackward Compatibility
Existing simulations using the
measureparameter will continue to work, but a deprecation warning will be logged encouraging users to migrate toendMeasurementTypes.Fixes #1089