Tolerate invalid AST from GNU label addresses#1797
Open
thedataking wants to merge 2 commits into
Open
Conversation
ahomescu
requested changes
May 12, 2026
Contributor
ahomescu
left a comment
ahomescu
left a comment
There was a problem hiding this comment.
The LabelDecl change should be split into a separate PR.
Do not try to export untranslated local labels as it leaves dangling decl ids behind.
GNU labels-as-values can make the exporter omit nodes. Keep traversal/comment passes from panicking on the resulting invalid AST. Missing expression placeholders now translate to an explicit unsupported-AST error instead of a missing-id panic.
thedataking
force-pushed
the
perl/gnu-labels-as-values
branch
from
62b295a to
0384fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle unsupported GNU labels-as-values gracefully.