transpile: Improve case translation#1776
Draft
Rua wants to merge 15 commits into
Draft
Conversation
Rua
force-pushed
the
pattern-conversion
branch
6 times, most recently
from
9211786 to
cc22e77
Compare
Rua
force-pushed
the
pattern-conversion
branch
2 times, most recently
from
e63622e to
8eca20d
Compare
Rua
changed the title
is_pattern to ExprContext for customized case translationcase translation
Rua
force-pushed
the
pattern-conversion
branch
2 times, most recently
from
6251ffa to
e437818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can_propagate_castfunction, elide some more casts #1770i32#1774Translating
casestatements is currently a very ad-hoc affair, so this is an attempt to make it a bit more generic and flexible.expr_to_patnow converts expressions to equivalent patterns, preserving the semantics and returningNoneif an expression with no equivalent is encountered.Translation functions can now use
is_patternto detect if they are translating an expression that's meant to appear inside a Rust pattern, and adjust accordingly. That will help towards getting #1775 to work. Currently, all expressions that cannot (conservatively) be translated in pattern context return a translation error. That will then trigger fallback to directly using theConstIntExprvalue that's provided inside theCasevalue.Additionally, it seems that it fixes a missing macro expansion in
macrocase.c, so that's a bonus!