Fix for misc.save_script_parameters (Issue #136)#140
Open
rohangirishrao wants to merge 6 commits intoimcf:develfrom
Open
Fix for misc.save_script_parameters (Issue #136)#140rohangirishrao wants to merge 6 commits intoimcf:develfrom
misc.save_script_parameters (Issue #136)#140rohangirishrao wants to merge 6 commits intoimcf:develfrom
Conversation
Attempt to fix the problem in a new branch, see imcf#136 for details.
This is necessary as calling globals from inside the method lead to no variables from the call time.
rohangirishrao
changed the title
m (Issue #136) misc.save_script_parameters (Issue #136)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #140 +/- ##
====================================
- Coverage 25% 25% -0%
====================================
Files 25 25
Lines 1761 1783 +22
====================================
+ Hits 443 444 +1
- Misses 1318 1339 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 25, 2026
Contributor
Author
|
Is there anything to be done for the codecov failing? There is no way to really test this part |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function now accepts
globals()as a parameter - this is a workaround as calling globals() from the method did not work, see #136.