-
Notifications
You must be signed in to change notification settings - Fork 3
Bdv update library #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bdv update library #118
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c669c0f
feat(bdv): Fix methods to work with latest BDV version
lguerard d19462d
Merge modifications made by @cellkai in #106
lguerard 679e5d3
fix(bdv): Clarify boolean parameter for headless command execution
lguerard 24126c7
Shorten comment on headless command execution
ehrenfeu 4700635
Update 'list_files' parameter documentation
ehrenfeu 8137c3c
Explain the 'p' in the function name
ehrenfeu db65398
Fix syntax
ehrenfeu a03a62e
Shorten descriptions, use imperative mood
ehrenfeu ee68e96
refactor(bdv): replace bdv class references with local definitions
lguerard 6e7bdfe
docs(bdv): update usage examples for fuse_dataset_bdvp function
lguerard 6308fbe
feat(pathtools): Refactor method in `pathtools`
lguerard a17e0a9
chore(pathtools): remove redundant import of os in join_files_with_ch…
lguerard 451f84c
Docstring syntax of usage examples
ehrenfeu 5611cb9
Merge branch 'devel' into bdv_update_library
ehrenfeu 4ebc024
Docstring fix for ruff D412
ehrenfeu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected to fail as
DefinitionOptionsis a class defined in this very file here.➡️ Nicely illustrates the need for unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have resolved the other comment, but will leave this one open for the unit test part.