Fix function to not split time points by default

[CellKai]

Needed because the current function is ignoring the user parameter and always splits by time point.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25%. Comparing base (4ebc024) to head (8a2c295).
⚠️ Report is 64 commits behind head on devel.

Additional details and impacted files

@@         Coverage Diff          @@
##           devel   #107   +/-   ##
====================================
  Coverage     25%    25%           
====================================
  Files         25     25           
  Lines       1772   1774    +2     
====================================
+ Hits         435    440    +5     
+ Misses      1337   1334    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ehrenfeu]

Would be nice to have this behavior explained in the function's docstring.

[ehrenfeu]

Actually, by its nature the parameter timepoints_per_partition should rather be boolean than int as it's only having two values with the semantics "split" or "don't split"...

Let's do this now as we're anyway aiming for a major release.

[ehrenfeu]

Actually, by its nature the parameter timepoints_per_partition should rather be boolean than int as it's only having two values with the semantics "split" or "don't split"...

Let's do this now as we're anyway aiming for a major release.

Got it wrong, it is indeed an int as it can also take numbers larger than 1, resulting in multiple timepoints being aggregated into a single HDF5 file.

➡️ Explain this in the docstring instead, but leave the code as it is.

[ehrenfeu]

🚨 The default behavior changed, so this has to be mentioned in the changelog (#126).

[ehrenfeu]

Pytest 🕵🏼 is failing, do we need to update the testing scripts to pull in the latest BDV / Fiji?

I guess this will also be the case for other PR's...

[ehrenfeu]

Merged back devel into this PR in order to fix the linting issues and to prevent merge conflicts.

🚨 @CellKai please make sure to git pull before working on the unit-tests in this PR!! 🚨

[ehrenfeu]

Test code at

python-imcflibs/tests/bdv/test_define_dataset_auto.py

Line 85 in d0c3274

options = (

ff. and

python-imcflibs/tests/bdv/test_define_dataset_auto.py

Line 149 in d0c3274

options = (

will need to be adapted.