Skip to content

fix: Update PR builder not to execute Sonar analysis#3486

Merged
iluwatar merged 1 commit into
masterfrom
update-maven-pr-builder
May 31, 2026
Merged

fix: Update PR builder not to execute Sonar analysis#3486
iluwatar merged 1 commit into
masterfrom
update-maven-pr-builder

Conversation

@iluwatar
Copy link
Copy Markdown
Owner

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

PR Summary

Disabled Sonar analysis in the PR builder workflow and simplified the Maven build. Changed the trigger from pull_request_target to pull_request, removed explicit head SHA checkout, dropped SonarCloud caching, and eliminated the SonarQube analysis step. The workflow now performs a straightforward Maven verification with xvfb-run ./mvnw clean verify.

Changes

File Summary
.github/workflows/maven-pr-builder.yml Updated PR builder workflow to use pull_request trigger, removed explicit head SHA checkout, dropped SonarCloud cache and SonarQube analysis, and simplified to run xvfb-run ./mvnw clean verify for Maven verification only.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 0c6e831: fix: Update PR builder not to execute Sonar analysis
Files Processed (1)
  • .github/workflows/maven-pr-builder.yml (3 hunks)
Actionable Comments (0)
Skipped Comments (3)
  • .github/workflows/maven-pr-builder.yml [4-4]

    config: "Use pull_request trigger"

  • .github/workflows/maven-pr-builder.yml [18-22]

    maintainability: "Checkout behavior: head vs merge"

  • .github/workflows/maven-pr-builder.yml [41-42]

    enhancement: "Add Maven build step using xvfb-run"

@iluwatar iluwatar merged commit e4384ef into master May 31, 2026
3 checks passed
@iluwatar iluwatar deleted the update-maven-pr-builder branch May 31, 2026 05:03
@sonarqubecloud
Copy link
Copy Markdown

@iluwatar
Copy link
Copy Markdown
Owner Author

iluwatar commented May 31, 2026

@all-contributors please add @nilsreichardt for security

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I've put up a pull request to add @nilsreichardt! 🎉

@iluwatar
Copy link
Copy Markdown
Owner Author

@all-contributors please add @north-echo for security

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I've put up a pull request to add @north-echo! 🎉

@iluwatar
Copy link
Copy Markdown
Owner Author

@all-contributors please add @dagecko for security

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I've put up a pull request to add @dagecko! 🎉

@iluwatar
Copy link
Copy Markdown
Owner Author

@all-contributors please add @jackmisbach for security

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I've put up a pull request to add @jackmisbach! 🎉

@iluwatar
Copy link
Copy Markdown
Owner Author

@all-contributors please add @avivdon for security

@allcontributors
Copy link
Copy Markdown
Contributor

@iluwatar

I've put up a pull request to add @avivdon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant