Fix. the issue #346 on igrigorik/em-http-request#347
Open
jabbadev wants to merge 1 commit intoigrigorik:masterfrom
Open
Fix. the issue #346 on igrigorik/em-http-request#347jabbadev wants to merge 1 commit intoigrigorik:masterfrom
jabbadev wants to merge 1 commit intoigrigorik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i had to apply this modify to fix the problem of the #346 issue.
with jruby 9.2 and http_parser.rb v0.6.0, thats instructions fails.
@p = Http::Parser.new
@p.header_value_type = :mixed
I think that the parser has a default header_value_type as "mixed" and is unnecessary the explicit assigment