Skip to content

Comments

error or x#447

Merged
ignatandrei merged 5 commits intomainfrom
ErrorOrX
Feb 8, 2026
Merged

error or x#447
ignatandrei merged 5 commits intomainfrom
ErrorOrX

Conversation

@ignatandrei
Copy link
Owner

@ignatandrei ignatandrei commented Feb 8, 2026

Summary by CodeRabbit

  • New Features

    • Added ErrorOrX (RSCG 253 bitskit #254), a discriminated union source generator for ASP.NET Core Minimal APIs with OpenAPI integration and Native AOT support.
    • Added interactive demo project and guided tour for the ErrorOrX example.
  • Documentation

    • Updated all example lists and indexes from 253 to 254 RSCG examples.
    • Added comprehensive documentation page, author information, and category updates for the new example.

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

This pull request adds ErrorOrX as the 254th RSCG example to the documentation and catalog system. Changes include the new example project implementation, CodeTour definitions, comprehensive documentation pages, author information, metadata entries, and catalog reorganizations across the documentation site.

Changes

Cohort / File(s) Summary
Core Example Project
v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj, DemoFuncAPI.http, Program.cs, PersonAPI.cs, Properties/launchSettings.json, appsettings.json, appsettings.Development.json, DemoFuncAPI.slnx
New ASP.NET Core minimal API example project demonstrating ErrorOrX integration with weather forecast and person API endpoints, error handling, and OpenAPI support.
Project Metadata & Configuration
v2/rscg_examples/ErrorOrX/description.json, nuget.txt, readme.txt, video.json
Added project metadata files including detailed README with features, usage examples, package information, and scripted demo tour instructions.
Data & Catalog Entries
v2/RSCGExamplesData/GeneratorDataRec.json, NoExample.json, v2/rscg_examples_site/static/exports/RSCG.json
Added ErrorOrX entry to generator data registry and exported catalog; removed invalid entry from NoExample tracking.
HTML Documentation
v2/book/examples/ErrorOrX.html, v2/book/list.html, v2/book/pandocHTML.yaml
Created new ErrorOrX HTML documentation page and updated list count from 253 to 254 entries; added file to pandoc configuration.
Tour & Navigation
v2/.tours/ErrorOrX.tour
Added CodeTour JSON file with step-by-step navigation through ErrorOrX project structure and generated files.
Documentation Site - RSCG Examples
v2/rscg_examples_site/docs/RSCG-Examples/ErrorOrX.md, v2/rscg_examples_site/docs/RSCG-Examples/index.md
Added comprehensive ErrorOrX documentation (1205 lines) covering features, code examples, installation, usage patterns, and OpenAPI integration; updated index to reference new example.
Documentation Site - Categories & Listings
v2/rscg_examples_site/docs/Categories/API.md, _PrimitiveAPI.mdx, NoExamples.md
Reorganized API category entries to reflect ErrorOrX as first item; reordered and renumbered all subsequent API generators; updated NoExamples entries.
Documentation Site - Author & Global Updates
v2/rscg_examples_site/docs/Authors/Alexander_Nachtmanns.md, about.md, indexRSCG.md, src/components/HomepageFeatures/index.js
Added author page for Alexander Nachtmanns; updated global references from 253 to 254 RSCG examples across multiple site pages.
Root Documentation
README.md, later.md
Updated project count from 253 to 254; changed "Latest Update" date from 2026-02-01 to 2026-02-02; expanded content section with ErrorOrX entry and v2 documentation links; substituted project references in "Why I have not tested" list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A hop, skip, and hop—now we're 254 strong!
ErrorOrX joins the fray, where examples belong.
With unions so sweet and APIs so tight,
Another fine addition to the RSCG light! ✨
From PersonAPI to WeatherForecast cheer,
The catalog grows—let's give three cheers!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'error or x' is vague and uses non-descriptive phrasing that doesn't convey meaningful information about the changeset's primary purpose. Use a more descriptive title that clearly indicates the main change, such as 'Add ErrorOrX code generator example' or 'Add RSCG example 254: ErrorOrX'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ErrorOrX

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 9

🤖 Fix all issues with AI agents
In `@v2/book/examples/ErrorOrX.html`:
- Around line 9-16: Fix the visible typos in the HTML snippet: change "Author
:Alexander Nachtmanns" to "Author: Alexander Nachtmanns" (add space after
colon), correct "ErroOrX" to "ErrorOrX" everywhere (e.g., in the sentence "API
results from Functional returns of ErroOrX"), and adjust casing for clarity to
something like "API results from functional returns of ErrorOrX." Update the
strings in the ErrorOrX.html content so the author line, source link context,
and About paragraph reflect these corrections.

In `@v2/rscg_examples_site/docs/RSCG-Examples/ErrorOrX.md`:
- Line 4: Fix the typo in the frontmatter description: change the string
"ErroOrX" to "ErrorOrX" so the description reads "API results from Functional
returns of ErrorOrX"; update the description field in the document header (the
YAML/frontmatter description) to use the corrected "ErrorOrX" identifier.
- Line 393: Replace the misspelled "ErroOrX" with the correct "ErrorOrX" in the
About section text; search for the string "ErroOrX" in the
RSCG-Examples/ErrorOrX.md content (the heading or descriptive paragraph) and
update all occurrences to "ErrorOrX" to fix the typo.

In `@v2/rscg_examples/ErrorOrX/description.json`:
- Line 12: The JSON value for the "goodFor" entry contains a typo ("ErroOrX");
update the string to "ErrorOrX" so the entry reads "API results from Functional
returns of ErrorOrX" by editing the "goodFor" value in description.json; ensure
quotation and comma punctuation remain valid JSON.

In `@v2/rscg_examples/ErrorOrX/readme.txt`:
- Line 22: The Features text shows "41 Analyzers" while the Analyzers table
header shows "38 Diagnostics"—pick the correct analyzer count and make both
labels consistent: update the Features entry ("41 Analyzers") or the Analyzers
table header ("38 Diagnostics") so they match the verified number, and search
the README for any other occurrences of "41 Analyzers" or "38 Diagnostics" to
update them as well (ensure wording like "Analyzers" vs "Diagnostics" is
consistent across headings and feature bullets).

In `@v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs`:
- Line 26: The exception message in PersonAPI.cs (the throw new Exception call
in the switch/case returning case 2) has a grammar mistake; update the string
from "person does not exists" to "person does not exist" so the thrown Exception
message is grammatically correct (locate the throw new Exception(...) in
PersonAPI.cs and change the message text).

In `@v2/rscg_examples/ErrorOrX/video.json`:
- Line 11: Fix the typo in the JSON text payload: inside the object with
"typeStep":"text" update the "arg" string to replace the misspelled "ErroOrX"
with "ErrorOrX" so the sentence reads "...Functional returns of ErrorOrX ."
(modify the value associated with "arg" in the relevant JSON entry).
- Around line 35-38: The JSON contains invalid syntax: change SpeakTest=" " to a
proper JSON property with double quotes and a colon ("SpeakTest": " ") inside
the object for the browser step, and remove the trailing comma after the
{"typeStep":"waitseconds","arg":"30"} entry so the array ends with ] without a
trailing comma; ensure all object keys are double-quoted and use colons (e.g.,
the objects in the array that include "typeStep" and "arg").
🧹 Nitpick comments (2)
v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs (1)

8-8: Route /todos/{id} seems mismatched for a PersonAPI class.

This appears to be copy-pasted from the Todo example in the readme. For a clearer demo, consider using /persons/{id} or /people/{id}.

v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.http (1)

1-6: The .http file only tests /weatherforecast/ — consider adding a request for the ErrorOrX endpoint.

This demo is for ErrorOrX, but the only HTTP request targets the weather endpoint. Adding a request like GET {{DemoFuncAPI_HostAddress}}/todos/1 would better demonstrate the ErrorOrX-generated endpoint.

Comment on lines +8 to +52
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj",
"description": "First, we add Nuget [ErrorOrX](https://www.nuget.org/packages/ErrorOrX/) in csproj ",
"pattern": "ErrorOrX"
}

,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs",
"description": "File PersonAPI.cs ",
"pattern": "this is the code"
}

,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/Program.cs",
"description": "File Program.cs \r\n>> dotnet run --project rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj ",
"pattern": "this is the code"
}


,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.OpenApiTransformerGenerator/OpenApiTransformers.g.cs",
"description": "Generated File 5 from 5 : OpenApiTransformers.g.cs ",
"line": 1
}

,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.ErrorOrEndpointGenerator/ErrorOrEndpoints.GlobalUsings.g.cs",
"description": "Generated File 4 from 5 : ErrorOrEndpoints.GlobalUsings.g.cs ",
"line": 1
}

,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.ErrorOrEndpointGenerator/ErrorOrEndpointOptions.g.cs",
"description": "Generated File 3 from 5 : ErrorOrEndpointOptions.g.cs ",
"line": 1
}

,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.ErrorOrEndpointGenerator/ErrorOrEndpointMappings.cs",
"description": "Generated File 2 from 5 : ErrorOrEndpointMappings.cs ",
"line": 1
}

,{
"file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.ErrorOrEndpointGenerator/ErrorOrEndpointAttributes.Mappings.g.cs",
"description": "Generated File 1 from 5 : ErrorOrEndpointAttributes.Mappings.g.cs ",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the actual structure and verify paths exist

echo "=== Checking tour file location and structure ==="
ls -la v2/.tours/ErrorOrX.tour 2>/dev/null || echo "Tour file not found"

echo ""
echo "=== Verifying paths WITHOUT v2/ prefix ==="
# Check if paths resolve from repo root without v2/
test -f "rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj" && echo "✓ rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj exists (repo root)" || echo "✗ rscg_examples/... NOT found from repo root"

echo ""
echo "=== Verifying paths WITH v2/ prefix ==="
# Check if paths resolve with v2/ prefix
test -f "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj" && echo "✓ v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj exists" || echo "✗ v2/rscg_examples/... NOT found"

echo ""
echo "=== Directory structure under v2 ==="
find v2 -type d -name "ErrorOrX" 2>/dev/null | head -5

echo ""
echo "=== Verifying patterns exist in referenced files ==="
# Check PersonAPI.cs
if [ -f "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs" ]; then
  echo "PersonAPI.cs found. Checking for pattern 'this is the code':"
  grep -n "this is the code" "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs" && echo "✓ Pattern found" || echo "✗ Pattern 'this is the code' NOT found"
fi

# Check Program.cs
if [ -f "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/Program.cs" ]; then
  echo "Program.cs found. Checking for pattern 'this is the code':"
  grep -n "this is the code" "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/Program.cs" && echo "✓ Pattern found" || echo "✗ Pattern 'this is the code' NOT found"
fi

echo ""
echo "=== Verifying generated files exist ==="
# Verify generated files
fd -H "OpenApiTransformers.g.cs" v2 2>/dev/null && echo "✓ OpenApiTransformers.g.cs exists" || echo "✗ OpenApiTransformers.g.cs NOT found"
fd -H "ErrorOrEndpoints.GlobalUsings.g.cs" v2 2>/dev/null && echo "✓ ErrorOrEndpoints.GlobalUsings.g.cs exists" || echo "✗ ErrorOrEndpoints.GlobalUsings.g.cs NOT found"
fd -H "ErrorOrEndpointOptions.g.cs" v2 2>/dev/null && echo "✓ ErrorOrEndpointOptions.g.cs exists" || echo "✗ ErrorOrEndpointOptions.g.cs NOT found"
fd -H "ErrorOrEndpointMappings.cs" v2 2>/dev/null && echo "✓ ErrorOrEndpointMappings.cs exists" || echo "✗ ErrorOrEndpointMappings.cs NOT found"
fd -H "ErrorOrEndpointAttributes.Mappings.g.cs" v2 2>/dev/null && echo "✓ ErrorOrEndpointAttributes.Mappings.g.cs exists" || echo "✗ ErrorOrEndpointAttributes.Mappings.g.cs NOT found"

Repository: ignatandrei/RSCG_Examples

Length of output: 948


🏁 Script executed:

#!/bin/bash
echo "=== PersonAPI.cs first 30 lines ==="
head -30 v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs

echo ""
echo "=== Program.cs content ==="
cat v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/Program.cs

Repository: ignatandrei/RSCG_Examples

Length of output: 1820


Fix CodeTour file paths and replace placeholder patterns with actual code.

The file paths are missing the v2/ prefix, which will break navigation. Additionally, the patterns "this is the code" for PersonAPI.cs and Program.cs are placeholder text that don't exist in the actual files—they need to be replaced with real code snippets from those files so the tour steps resolve correctly.

Examples of required fixes
-      "file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj",
+      "file": "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/DemoFuncAPI.csproj",

-        "file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs",
-        "pattern": "this is the code"
+        "file": "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs",
+        "pattern": "public static ErrorOr<Person> GetById"

-        "file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/Program.cs",
-        "pattern": "this is the code"
+        "file": "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/Program.cs",
+        "pattern": "builder.Services.AddErrorOrOpenApi"

-        "file": "rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.OpenApiTransformerGenerator/OpenApiTransformers.g.cs",
+        "file": "v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/obj/GX/ErrorOrX.Generators/ErrorOr.Generators.OpenApiTransformerGenerator/OpenApiTransformers.g.cs",

Comment on lines +9 to +16
<p>Author :Alexander Nachtmanns</p>

<p>Source: <a href="https://github.com/ANcpLua/ErrorOrX/" target="_blank">https://github.com/ANcpLua/ErrorOrX/</a> </p>

<h2>About</h2>

API results from Functional returns of ErroOrX

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix user-facing typos in the About/Author text.

Minor but visible formatting/typo issues.

✏️ Proposed fix
-<p>Author :Alexander Nachtmanns</p>
+<p>Author: Alexander Nachtmanns</p>
@@
-API results from Functional returns of ErroOrX
+<p>API results from functional returns of ErrorOrX</p>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<p>Author :Alexander Nachtmanns</p>
<p>Source: <a href="https://github.com/ANcpLua/ErrorOrX/" target="_blank">https://github.com/ANcpLua/ErrorOrX/</a> </p>
<h2>About</h2>
API results from Functional returns of ErroOrX
<p>Author: Alexander Nachtmanns</p>
<p>Source: <a href="https://github.com/ANcpLua/ErrorOrX/" target="_blank">https://github.com/ANcpLua/ErrorOrX/</a> </p>
<h2>About</h2>
<p>API results from functional returns of ErrorOrX</p>
🤖 Prompt for AI Agents
In `@v2/book/examples/ErrorOrX.html` around lines 9 - 16, Fix the visible typos in
the HTML snippet: change "Author :Alexander Nachtmanns" to "Author: Alexander
Nachtmanns" (add space after colon), correct "ErroOrX" to "ErrorOrX" everywhere
(e.g., in the sentence "API results from Functional returns of ErroOrX"), and
adjust casing for clarity to something like "API results from functional returns
of ErrorOrX." Update the strings in the ErrorOrX.html content so the author
line, source link context, and About paragraph reflect these corrections.

---
sidebar_position: 2540
title: 254 - ErrorOrX
description: API results from Functional returns of ErroOrX
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in description.

The description contains a typo: "ErroOrX" should be "ErrorOrX".

✏️ Proposed fix
-description: API results from Functional returns of ErroOrX
+description: API results from Functional returns of ErrorOrX
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
description: API results from Functional returns of ErroOrX
description: API results from Functional returns of ErrorOrX
🤖 Prompt for AI Agents
In `@v2/rscg_examples_site/docs/RSCG-Examples/ErrorOrX.md` at line 4, Fix the typo
in the frontmatter description: change the string "ErroOrX" to "ErrorOrX" so the
description reads "API results from Functional returns of ErrorOrX"; update the
description field in the document header (the YAML/frontmatter description) to
use the corrected "ErrorOrX" identifier.

### About
:::note

API results from Functional returns of ErroOrX
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in About section.

The About section contains the same typo: "ErroOrX" should be "ErrorOrX".

✏️ Proposed fix
-API results from Functional returns of ErroOrX
+API results from Functional returns of ErrorOrX
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
API results from Functional returns of ErroOrX
API results from Functional returns of ErrorOrX
🧰 Tools
🪛 LanguageTool

[grammar] ~393-~393: Ensure spelling is correct
Context: ... API results from Functional returns of ErroOrX ::: ## How to use ### Example (source ...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents
In `@v2/rscg_examples_site/docs/RSCG-Examples/ErrorOrX.md` at line 393, Replace
the misspelled "ErroOrX" with the correct "ErrorOrX" in the About section text;
search for the string "ErroOrX" in the RSCG-Examples/ErrorOrX.md content (the
heading or descriptive paragraph) and update all occurrences to "ErrorOrX" to
fix the typo.

"source":"https://github.com/ANcpLua/ErrorOrX"
},
"data":{
"goodFor":["API results from Functional returns of ErroOrX"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "ErroOrX" should be "ErrorOrX".

The goodFor description has a typo — missing an 'r'.

✏️ Proposed fix
-      "goodFor":["API results from Functional returns of ErroOrX"],
+      "goodFor":["API results from Functional returns of ErrorOrX"],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"goodFor":["API results from Functional returns of ErroOrX"],
"goodFor":["API results from Functional returns of ErrorOrX"],
🤖 Prompt for AI Agents
In `@v2/rscg_examples/ErrorOrX/description.json` at line 12, The JSON value for
the "goodFor" entry contains a typo ("ErroOrX"); update the string to "ErrorOrX"
so the entry reads "API results from Functional returns of ErrorOrX" by editing
the "goodFor" value in description.json; ensure quotation and comma punctuation
remain valid JSON.

- **Middleware Support** - Translates ASP.NET Core attributes to Minimal API fluent calls (authorization, rate limiting,
caching)
- **API Versioning** - Integrates with Asp.Versioning.Http for versioned endpoint groups
- **41 Analyzers** - Real-time IDE feedback for route conflicts, binding errors, AOT compatibility
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent analyzer count: "41 Analyzers" (Line 22) vs "38 Diagnostics" (Line 107).

The Features section says "41 Analyzers" but the Analyzers table header says "38 Diagnostics." Please reconcile these numbers.

🤖 Prompt for AI Agents
In `@v2/rscg_examples/ErrorOrX/readme.txt` at line 22, The Features text shows "41
Analyzers" while the Analyzers table header shows "38 Diagnostics"—pick the
correct analyzer count and make both labels consistent: update the Features
entry ("41 Analyzers") or the Analyzers table header ("38 Diagnostics") so they
match the verified number, and search the README for any other occurrences of
"41 Analyzers" or "38 Diagnostics" to update them as well (ensure wording like
"Analyzers" vs "Diagnostics" is consistent across headings and feature bullets).

id switch
{
1 => new Person(1, "John Doe"),
2 => throw new Exception("person does not exists"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Grammar: "person does not exists" → "person does not exist".

✏️ Proposed fix
-            2 => throw new Exception("person does not exists"),
+            2 => throw new Exception("person does not exist"),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
2 => throw new Exception("person does not exists"),
2 => throw new Exception("person does not exist"),
🤖 Prompt for AI Agents
In `@v2/rscg_examples/ErrorOrX/src/DemoFuncAPI/PersonAPI.cs` at line 26, The
exception message in PersonAPI.cs (the throw new Exception call in the
switch/case returning case 2) has a grammar mistake; update the string from
"person does not exists" to "person does not exist" so the thrown Exception
message is grammatically correct (locate the throw new Exception(...) in
PersonAPI.cs and change the message text).

{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/List-of-RSCG"},
{"typeStep":"text","arg": "My name is Andrei Ignat and I am deeply fond of Roslyn Source Code Generator. "},

{"typeStep":"text","arg": "Today I will present ErrorOrX . API results from Functional returns of ErroOrX ."},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "ErroOrX" → "ErrorOrX".

✏️ Proposed fix
-{"typeStep":"text","arg": "Today I will present ErrorOrX . API results from Functional returns of ErroOrX ."},
+{"typeStep":"text","arg": "Today I will present ErrorOrX . API results from Functional returns of ErrorOrX ."},
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{"typeStep":"text","arg": "Today I will present ErrorOrX . API results from Functional returns of ErroOrX ."},
{"typeStep":"text","arg": "Today I will present ErrorOrX . API results from Functional returns of ErrorOrX ."},
🤖 Prompt for AI Agents
In `@v2/rscg_examples/ErrorOrX/video.json` at line 11, Fix the typo in the JSON
text payload: inside the object with "typeStep":"text" update the "arg" string
to replace the misspelled "ErroOrX" with "ErrorOrX" so the sentence reads
"...Functional returns of ErrorOrX ." (modify the value associated with "arg" in
the relevant JSON entry).

Comment on lines +35 to +38
{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/ErrorOrX#download-example-net--c-",
SpeakTest=" "},
{"typeStep":"waitseconds","arg":"30"},
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Invalid JSON syntax will cause parse failures.

Two issues here:

  1. SpeakTest=" " uses = instead of : and the key is not double-quoted — this is not valid JSON.
  2. Line 38 has a trailing comma before ], which is also invalid JSON.
🐛 Proposed fix
-{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/ErrorOrX#download-example-net--c-",
-SpeakTest=" "},
-{"typeStep":"waitseconds","arg":"30"},
+{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/ErrorOrX#download-example-net--c-",
+"SpeakTest":" "},
+{"typeStep":"waitseconds","arg":"30"}
 ]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/ErrorOrX#download-example-net--c-",
SpeakTest=" "},
{"typeStep":"waitseconds","arg":"30"},
]
{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/ErrorOrX#download-example-net--c-",
"SpeakTest": " "},
{"typeStep":"waitseconds","arg":"30"}
]
🧰 Tools
🪛 Biome (2.3.13)

[error] 35-36: Property key must be double quoted

(parse)


[error] 36-36: unexpected character =

(parse)


[error] 36-36: expected , but instead found " "

Remove " "

(parse)


[error] 36-36: expected : but instead found }

Remove }

(parse)


[error] 37-38: Expected an array, an object, or a literal but instead found ']'.

Expected an array, an object, or a literal here.

(parse)

🤖 Prompt for AI Agents
In `@v2/rscg_examples/ErrorOrX/video.json` around lines 35 - 38, The JSON contains
invalid syntax: change SpeakTest=" " to a proper JSON property with double
quotes and a colon ("SpeakTest": " ") inside the object for the browser step,
and remove the trailing comma after the {"typeStep":"waitseconds","arg":"30"}
entry so the array ends with ] without a trailing comma; ensure all object keys
are double-quoted and use colons (e.g., the objects in the array that include
"typeStep" and "arg").

@ignatandrei ignatandrei merged commit d09d9d7 into main Feb 8, 2026
3 checks passed
@ignatandrei ignatandrei deleted the ErrorOrX branch February 8, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant