Provide a WholeProjectDecompiler constructor with no default parameter values

[ds5678]

Problem

I'm trying to trim types from my application, and I'm having issues with the NativeAOT compiler not realizing that my parameters are never null.

ILSpy/ICSharpCode.Decompiler/CSharp/ProjectDecompiler/WholeProjectDecompiler.cs

Line 130 in 9898add

AssemblyReferenceClassifier = assemblyReferenceClassifier ?? new AssemblyReferenceClassifier();

ILSpy/ICSharpCode.Decompiler/CSharp/ProjectDecompiler/WholeProjectDecompiler.cs

Line 132 in 9898add

this.projectWriter = projectWriter ?? (Settings.UseSdkStyleProjectFormat ? ProjectFileWriterSdkStyle.Create() : ProjectFileWriterDefault.Create());

Solution

• I created an interface IAssemblyReferenceClassifier and replaced most uses of AssemblyReferenceClassifier with it.
• I moved default initialization from the most specific WholeProjectDecompiler constructor to the second most one.
• I added ArgumentNullException checks to the most specific WholeProjectDecompiler constructor.

[siegfriedpammer]

Thank you for your contribution!