[fix] Get right Column when use custom element replace text content.#417
Open
SuperSuperPepper wants to merge 1 commit intoicsharpcode:masterfrom
Open
[fix] Get right Column when use custom element replace text content.#417SuperSuperPepper wants to merge 1 commit intoicsharpcode:masterfrom
SuperSuperPepper wants to merge 1 commit intoicsharpcode:masterfrom
Conversation
Member
|
I tested your fix using ICSharpCode.AvalonEdit.Sample which contains the Maybe there is something wrong with your custom element generator? Hard to say, without access to your code. Please take a look at our sample code. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you want to use custom elements replace text content.
example: I want to use custom elements to change some keywords by using the menu, button or other elements for my special feature.
you will get the wrong caret position when you click textview .
because GetVisualColumn doesn't calculate generator elements. so need to recalculate the column.
this PR can fix #416