fix(metamcp): skip internal postgres config when using external DATAB…#35
Closed
balnibarbian wants to merge 1 commit intoicoretech:mainfrom
Closed
fix(metamcp): skip internal postgres config when using external DATAB…#35balnibarbian wants to merge 1 commit intoicoretech:mainfrom
balnibarbian wants to merge 1 commit intoicoretech:mainfrom
Conversation
…ASE_URL When users provide `env.DATABASE_URL` to use an external PostgreSQL database, the chart should not: - Create the wait-db init container that waits for internal postgres - Inject internal postgres environment variables (POSTGRES_HOST, PGHOST, etc.) - Reference the internal postgres secret This allows users to use external databases without needing to create dummy secrets or deal with init containers waiting for non-existent services. Fixes the issue where `postgres.enabled: false` with external `DATABASE_URL` still required manual workarounds.
Member
|
I opened #38 which cherry-picks this change and adds the required chart version bump (ct version-gate). This PR is cross-repo and "maintainer can modify" is disabled, so I can't push the version bump commit here directly. |
Member
|
Merged in #38 (includes the required chart version bump + maintainer metadata fix for ct lint). Closing this PR to avoid duplicate merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users provide
env.DATABASE_URLto use an external PostgreSQL database, the chart should not:This allows users to use external databases without needing to create dummy secrets or deal with init containers waiting for non-existent services.
Fixes the issue where
postgres.enabled: falsewith externalDATABASE_URLstill required manual workarounds.