Skip to content

Update colors#4

Merged
luu-alex merged 3 commits intoadd-privyfrom
update-colors
Mar 19, 2026
Merged

Update colors#4
luu-alex merged 3 commits intoadd-privyfrom
update-colors

Conversation

@luu-alex
Copy link

No description provided.

@luu-alex luu-alex merged commit 805085d into add-privy Mar 19, 2026
3 of 4 checks passed
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the application's primary color scheme by introducing a new set of primary color variables and a dedicated primary text color. These changes are applied across both light and dark themes, enhancing the overall visual consistency and modernizing the UI's appearance. The update also includes a specific adjustment to a trade panel button to correctly utilize the new text color under certain conditions.

Highlights

  • Color Palette Update: The primary color variables (--primary-default, --primary-hover, --primary-active, --primary-muted) have been significantly updated for both light and dark themes in src/styles.css.
  • New Primary Text Color: A new CSS variable, --primary-text, has been introduced in src/styles.css for both themes and mapped to --color-primary-text.
  • Conditional Styling Application: The TradePanel component now conditionally applies the new text-primary-text class to its main action button when the user is not connected, ensuring visual consistency with the updated color scheme.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the primary color palette for both light and dark themes and introduces a new primary-text color. This new color is then used on the main action button in the trade panel. The change to the button's class is a good step, but it only fixes the text color for the disconnected state. I've suggested a small modification to apply the fix for all button states, ensuring text is always readable in both themes.

onClick={buttonContent.action}
disabled={buttonContent.disabled}
className={cn("w-full")}
className={cn("w-full", !isConnected && "text-primary-text")}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change correctly addresses the text color issue for the button when not connected. However, when connected, the button text will still be unreadable in dark mode because the default text-white from the button's style has very low contrast against the new light-colored primary background (#D5F7FB).

To ensure the button text is always readable regardless of the connection state, you can apply the text-primary-text class unconditionally. This will fix the issue for all button states in both light and dark themes.

Suggested change
className={cn("w-full", !isConnected && "text-primary-text")}
className={cn("w-full", "text-primary-text")}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant