Repository navigation
Conversation
cratelyn
added
C-feature
in #340 (7539356), we addressed warnings in all of the feature combinations. this commit includes further changes building upon that work, to provide a fix for hyperium/hyper#3842. users building hyper-util for certain platforms were finding that the legacy client was no longer compatible after #218 and #276, which moved the `tokio/net` feature behind the `client-legacy` flag. this led to the introduction of a dependency on `mio` via `tokio` where there was previously none, breaking builds for Fuschia and Wasm. this commit introduces a feature flag, `client-legacy-http-connector`. this commit gates the use of types like `tokio::net::TcpStream` behind this flag, which end up only being used by the legacy `HttpConnector`. this permits use of the legacy client and the connector types for alternative target platforms, while providing a way for typical users to continue to opt into this ergonomic, default connector. crate-level documentation outlining the list of features is updated to include this feature, and the `check-client-features` recipe used in CI is updated to include this feature in its exploration space. to confirm that this works for a platform like wasm, this `cargo-hack` command can be used: ``` ; cargo hack check --include-features client,client-legacy,http1,http2,client-pool --target=wasm32-wasip2 --feature-powerset ``` to confirm that other native platforms work, try this: ``` cargo hack check --include-features client,client-legacy,http1,http2,client-pool,tokio --feature-powerset ``` Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
force-pushed
the
kate/wasm-compatible-legacy-client
branch
from
October 9, 2026 22:26
60df174 to
0dbb8bb
Compare
cratelyn
marked this pull request as ready for review
October 9, 2026 22:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #340 (7539356), we addressed warnings in all of the feature combinations. this commit includes further changes building upon that work, to provide a fix for hyperium/hyper#3842.
users building hyper-util for certain platforms were finding that the legacy client was no longer compatible after #218 and #276, which moved the
tokio/netfeature behind theclient-legacyflag. this led to the introduction of a dependency onmioviatokiowhere there was previously none, breaking builds for Fuschia and Wasm.this commit introduces a feature flag,
client-legacy-http-connector. this commit gates the use of types liketokio::net::TcpStreambehind this flag, which end up only being used by the legacyHttpConnector.this permits use of the legacy client and the connector types for alternative target platforms, while providing a way for typical users to continue to opt into this ergonomic, default connector.
crate-level documentation outlining the list of features is updated to include this feature, and the
check-client-featuresrecipe used in CI is updated to include this feature in its exploration space.to confirm that this works for a platform like wasm, this
cargo-hackcommand can be used:to confirm that other native platforms work, try this: