fix(flux): decouple modular flux from classic and qwenimage imports#13958
Open
akshan-main wants to merge 1 commit into
Open
fix(flux): decouple modular flux from classic and qwenimage imports#13958akshan-main wants to merge 1 commit into
akshan-main wants to merge 1 commit into
Conversation
Contributor
|
Hi @akshan-main, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses Issue 6 of the flux review (#13584). The modular Flux blocks imported
FluxPipeline._pack_latentsand_prepare_latent_image_ids, the classic KontextPREFERRED_KONTEXT_RESOLUTIONSconstant, and two QwenImage modular helpers. This replaces those cross-imports with flux-modular-local copies, followingdecoders.py.The coupling check from the issue returns nothing and the modular flux tests pass.
Before submitting
Who can review?
@DN6 @sayakpaul @yiyixuxu