fix(flux): enable true CFG with precomputed negative embeds#13957
Open
akshan-main wants to merge 2 commits into
Open
fix(flux): enable true CFG with precomputed negative embeds#13957akshan-main wants to merge 2 commits into
akshan-main wants to merge 2 commits into
Conversation
…g/inpaint/controlnet
Contributor
|
Hi @akshan-main, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses the flux review (#13584), Issue 2:
FluxImg2ImgPipeline,FluxInpaintPipeline, andFluxControlNetPipelinegated true CFG ontrue_cfg_scale > 1 and negative_prompt is not None, so passing precomputednegative_prompt_embeds/negative_pooled_prompt_embeds(withnegative_prompt=None) silently did not enable CFG.Base
FluxPipeline(andFluxKontextPipeline) already handle this correctly:This brings the three pipelines in line. The downstream
if do_true_cfg:block already forwards the precomputed embeds throughencode_prompt, so only the gate needed fixing. Verified the gate flipsFalse -> Truefor the precomputed-embeds case and copies/ruff stay clean.Before submitting
Who can review?
@hlky @sayakpaul @yiyixuxu