Skip to content

Log VQ remapping configuration through the model logger#13939

Open
wunianze666-netizen wants to merge 2 commits into
huggingface:mainfrom
wunianze666-netizen:fix/vq-remap-logging
Open

Log VQ remapping configuration through the model logger#13939
wunianze666-netizen wants to merge 2 commits into
huggingface:mainfrom
wunianze666-netizen:fix/vq-remap-logging

Conversation

@wunianze666-netizen

@wunianze666-netizen wunianze666-netizen commented Jun 13, 2026

Copy link
Copy Markdown

Summary

  • route VectorQuantizer remap configuration output through the model logger instead of writing directly to stdout
  • add a regression test that expects the remap message to be logged when remapping is enabled

Why

This message is emitted from library/model initialization code. Sending it to stdout makes it harder for downstream users to manage output, while the logger keeps the signal available without forcing terminal noise.

Validation

  • added a targeted regression test for the remap logging path
  • verified the updated source and test files with py_compile
  • ran a source-level regression check to confirm the remap notice is no longer implemented with print(...)

Issue Linkage

This is a small logging cleanup and is not tied to an existing tracked issue.

Note

The full pytest dependency set was not available in the current local Python environment, so validation was done with targeted static checks plus compile-time verification.

@github-actions github-actions Bot added models tests size/L PR with diff > 200 LOC labels Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @wunianze666-netizen, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant