[Core] Fix community pipeline initialization compatibility with primitive types#13874
Open
ProgramerSalar wants to merge 1 commit into
Open
[Core] Fix community pipeline initialization compatibility with primitive types#13874ProgramerSalar wants to merge 1 commit into
ProgramerSalar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes Issue #6969.
When the
image_encoderargument was added to the base pipeline, it shifted the order of positional arguments. This caused legacy community pipelines (likeBingsu/regional-prompter) that instantiate viasuper().__init__(...)with an ordered list to accidentally pass primitive types (like booleans) into theimage_encoderslot. This resulted in anAttributeError: 'bool' object has no attribute '__module__'when the library attempted to register the module.This PR adds a defensive type check
isinstance(module, (bool, int, float, str))inside_fetch_class_library_tupleto safely returnNone, None, allowing these legacy community pipelines to load seamlessly without crashing.Fixes #6969
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Core library: