Fix #1623: Decode percent-encoded characters in URL credentials - #1931
Open
vinayK34 wants to merge 1 commit into
Open
Fix #1623: Decode percent-encoded characters in URL credentials#1931vinayK34 wants to merge 1 commit into
vinayK34 wants to merge 1 commit into
Conversation
This fixes the issue where username/password in URLs were not being decoded before authentication. For example, a URL like 'https://u%40d:***@httpbin.org/basic-auth/u%40d/1%3d2%3f' would use the literal encoded values instead of decoding them to 'u@d' and '1=2?'. The fix adds decoding of percent-encoded characters in both username and password when they are extracted from URLs in the _process_auth method.
vinayK34
marked this pull request as ready for review
August 11, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where username/password in URLs were not being decoded before authentication.
For example, a URL like
https://u%40d:***@httpbin.org/basic-auth/u%40d/1%3d2%3fwould use the literal encoded values instead of decoding them to 'u@d' and '1=2?'.The fix adds decoding of percent-encoded characters in both username and password when they are extracted from URLs in the
_process_authmethod.