Fix python implementation marker for setuptools 2.20#227
Merged
gsnedders merged 1 commit intohtml5lib:masterfrom Mar 24, 2016
Merged
Fix python implementation marker for setuptools 2.20#227gsnedders merged 1 commit intohtml5lib:masterfrom
gsnedders merged 1 commit intohtml5lib:masterfrom
Conversation
Current coverage is
|
|
Critic review: https://critic.hoppipolla.co.uk/r/6233 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Member
|
Bah, Travis failing because of pip dropping 3.2 support. On the upside, easy to fix: we drop 3.2 support. |
Member
|
@paradoxxxzero Sorry for the delay; can you rebase this on master? |
Contributor
Author
|
Done sorry for the delay :) |
|
This breaks setup on older setuptools (this is my system setuptools): |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise setup.py fail with
error in html5lib setup command: Invalid environment marker: python_implementation == 'CPython'