Skip to content

Convert vim.NIL in client response item and itemDefaults to nil#2217

Merged
wsdjeg merged 1 commit intohrsh7th:mainfrom
ErikReider:fix-labelDetails-vim.NIL
Mar 25, 2026
Merged

Convert vim.NIL in client response item and itemDefaults to nil#2217
wsdjeg merged 1 commit intohrsh7th:mainfrom
ErikReider:fix-labelDetails-vim.NIL

Conversation

@ErikReider
Copy link
Copy Markdown
Contributor

Fixes: #2212

@ErikReider ErikReider force-pushed the fix-labelDetails-vim.NIL branch from 585f685 to f9984f6 Compare February 26, 2026 12:28
@ErikReider ErikReider marked this pull request as ready for review February 26, 2026 12:28
@ErikReider ErikReider changed the title Fixed completion_item.labelDetails checking for nil, not vim.NIL Convert vim.NIL in client response item and itemDefaults to nil Feb 26, 2026
@wsdjeg
Copy link
Copy Markdown
Collaborator

wsdjeg commented Feb 26, 2026

Hmm, why the job is failed, maybe need to check the ci system.

@ErikReider
Copy link
Copy Markdown
Contributor Author

@wsdjeg sorry for the ping, but is there anything that needs changing?

@wsdjeg wsdjeg merged commit 3d28a52 into hrsh7th:main Mar 25, 2026
0 of 2 checks passed
@wsdjeg
Copy link
Copy Markdown
Collaborator

wsdjeg commented Mar 25, 2026

merged, thanks:)

@saatom
Copy link
Copy Markdown

saatom commented Mar 28, 2026

Maybe it's something with my setup but this commit causes cmp to intermittently break. If I repeatedly run nvim test.txt, one out of every three or four times I will get the following error whenever I try to type a command in the (nvim) command line (or do anything that would normally invoke cmp).

Reverting to commit da88697 fixes this issue, thus I suspect something in this commit is the culprit. Can anyone else corroborate this issue?
Screenshot_20260328_100614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lua/cmp/entry.lua:351: attempt to concatenate field 'descriptio n' (a userdata value)

3 participants