Skip to content

Update CONTRIBUTING.md#31668

Open
vaibhav154 wants to merge 1 commit intohelm:mainfrom
vaibhav154:feature/doc-update
Open

Update CONTRIBUTING.md#31668
vaibhav154 wants to merge 1 commit intohelm:mainfrom
vaibhav154:feature/doc-update

Conversation

@vaibhav154
Copy link
Copy Markdown

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Signed-off-by: vaibhav154 <36911520+vaibhav154@users.noreply.github.com>
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2025
Copy link
Copy Markdown
Contributor

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CONTRIBUTING.md
Comment on lines +304 to +306

- Applying labels and milestones

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Applying labels and milestones
- Applying labels and milestones

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That suggestion didn't come out like I expected. My request is no empty lines in the middle of the list

Comment thread CONTRIBUTING.md
Comment on lines +303 to +307
- Reviewing new issues and PRs

- Applying labels and milestones

- Keeping queues manageable
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Reviewing new issues and PRs
- Applying labels and milestones
- Keeping queues manageable
- Reviewing new issues and PRs
- Applying labels and milestones
- Keeping queues manageable

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as @TerryHowe 's suggestion -- remove the blank lines between list items please

Copy link
Copy Markdown
Member

@gjenkins8 gjenkins8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants