Don't emit pointless copy-to-host in CPU only pipelines#9139
Open
abadams wants to merge 2 commits into
Open
Conversation
Running inject_host_dev_buffer_copies on CPU-only pipelines was injecting no-op copy-to-host calls. Benign, but they clutter the profiler output. They're guaranteed to be no-ops because they come after an assertion that device_dirty is false. This commit just manually sets host dirty flags in AddImageChecks alongside the code that asserts device_dirty is false, instead of running the full inject_host_dev_buffer_copies pass on CPU-only pipelines.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9139 +/- ##
=======================================
Coverage ? 69.79%
=======================================
Files ? 255
Lines ? 77527
Branches ? 18534
=======================================
Hits ? 54109
Misses ? 17968
Partials ? 5450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running inject_host_dev_buffer_copies on CPU-only pipelines was injecting no-op copy-to-host calls. Benign, but they clutter the profiler output. They're guaranteed to be no-ops because they come after an assertion that device_dirty is false.
This PR just manually sets host dirty flags in AddImageChecks alongside the code that asserts device_dirty is false, instead of running the full pass.
I also removed a pointless false-initialization of a field that was already set to false at the member declaration.