Skip to content

HCK-12141: Add support of non check #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nightlngale merged 7 commits into from
Jul 30, 2025
Merged

HCK-12141: Add support of non check #145

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9206c1c
HCK-12141: Generate FK name if necessary
Nightlngale Jul 29, 2025
aeff809
HCK-12141: Improve no check constraint
Nightlngale Jul 29, 2025
e48aac8
HCK-12142: Do not decorate default value
Nightlngale Jul 29, 2025
9d324db
HCK-12142: Do not decorate default value in some cases
Nightlngale Jul 29, 2025
6a305cf
Merge branch 'develop' into HCK-12141
serhii-filonenko Jul 30, 2025
8b33dce
HCK-12141: Improve logic of escaping single quotes for default value
Nightlngale Jul 30, 2025
9fc3d00
Temporary revert the logic of wrapping default values in single quotes
Nightlngale Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/configs/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = {

spatialIndex: 'CREATE SPATIAL INDEX ${name} ON ${table} (${column})${using}\n${options}${terminator}\n',

checkConstraint: 'CONSTRAINT [${name}] CHECK${notForReplication} (${expression})',
checkConstraint: 'CONSTRAINT [${name}] ${check}${notForReplication} (${expression})',

createForeignKeyConstraint:
'CONSTRAINT ${name} FOREIGN KEY (${foreignKey}) REFERENCES ${primaryTable} (${primaryKey}) ${onDelete}${onUpdate}',
Expand Down
2 changes: 2 additions & 0 deletions forward_engineering/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ module.exports = (baseProvider, options, app) => {
createCheckConstraint(checkConstraint) {
return assignTemplates(templates.checkConstraint, {
name: checkConstraint.name,
check: checkConstraint.check ? 'CHECK' : 'NO CHECK',
notForReplication: checkConstraint.enforceForReplication ? '' : ' NOT FOR REPLICATION',
expression: _.trim(checkConstraint.expression).replace(/^\(([\s\S]*)\)$/, '$1'),
terminator,
Expand Down Expand Up @@ -533,6 +534,7 @@ module.exports = (baseProvider, options, app) => {
hydrateCheckConstraint(checkConstraint) {
return {
name: checkConstraint.chkConstrName,
check: checkConstraint.constrCheck,
expression: checkConstraint.constrExpression,
existingData: checkConstraint.constrCheck,
enforceForUpserts: checkConstraint.constrEnforceUpserts,
Expand Down
2 changes: 1 addition & 1 deletion forward_engineering/helpers/columnDefinitionHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ module.exports = app => {

const decorateDefault = (type, defaultValue) => {
if (isString(type) && defaultValue !== 'NULL') {
return `'${escapeQuotes(defaultValue)}'`;
return escapeQuotes(defaultValue);
} else if (type === 'XML') {
return `CAST(N'${defaultValue}' AS xml)`;
}
Expand Down