Skip to content

User search query hook#2019

Merged
trillium merged 2 commits intohackforla:developmentfrom
jng34:userSearchQueryHook
Feb 3, 2026
Merged

User search query hook#2019
trillium merged 2 commits intohackforla:developmentfrom
jng34:userSearchQueryHook

Conversation

@jng34
Copy link
Member

@jng34 jng34 commented Oct 8, 2025

Fixes #2008

What changes did you make and why did you make them ?

  • replaced search query that originally used useState hook with useContext hook
  • allows users to retain previous search queries when navigating back and forth

Fixes #1999

What changes did you make and why did you make them ?

  • resolved bug that prevented updates to user profiles
  • search queries and profile edits persist when toggling between all searches

Screenshots of Proposed Changes Of The Website

Visuals of applied changes image image image

@trillium
Copy link
Member

trillium commented Oct 8, 2025

Hey James, thanks for working on another PR! Would you mind double checking the files you staged and comitted? Some Python changes are in your commited code here.

@jng34
Copy link
Member Author

jng34 commented Oct 9, 2025

@trillium which particular file(s) are you referring to? I do not see any changes to any Python code.

@trillium
Copy link
Member

trillium commented Oct 9, 2025

Weird, I could have sworn I saw python changes related to this PR but I don't see them any longer 🤷‍♂️

@JackHaeg
Copy link
Member

Discussed with @trillium on the call - this PR is ready to be reviewed :)

@JackHaeg
Copy link
Member

Added "waiting to merge" label for now, because @jng34 is still working on addressing the persistence of the profile edits (changes to statuses and projects), which will be added to this PR.

@jng34
Copy link
Member Author

jng34 commented Oct 31, 2025

Issue #1999 has been resolved in the latest commit. Ready for review and merge.

@jng34 jng34 requested a review from trillium October 31, 2025 19:36
@JackHaeg
Copy link
Member

JackHaeg commented Nov 4, 2025

Thanks @jng34! @trillium this PR is ready for your review / merge whenever you have a moment :)

@JackHaeg
Copy link
Member

@trillium please take a look at this PR when you have a moment :)

@trillium trillium force-pushed the userSearchQueryHook branch from 685b804 to 69d9ac4 Compare February 3, 2026 02:44
Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto latest development. Clean React Context refactor eliminating prop drilling. LGTM.

@trillium trillium merged commit df26aff into hackforla:development Feb 3, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create user search query hook Return to Correct Search Results After Editing User Profile

3 participants