Unit Testing for Auth Router#1927
Conversation
|
Hi @jng34 - It looks like there are some conflicts in this PR. Can you please resolve these conflicts when you have a moment? |
|
@JackHaeg Oops! I might have made a mistake. Let me confirm again once resolved. Sorry! |
|
@JackHaeg The conflict should be resolved. |
|
@dannyprikaz FYI - this PR is now ready for review per @jng34 👍 |
|
@jng34 This is the PR that was discussed on tonight's call. Please take a look at it when you have a moment to double check if this was closed by accident :) |
|
@JackHaeg I was removing old branches on my local machine, and might have deleted the branch associated with this PR. I don't think it should have closed the PR though...weird. Anyway, I have reopened it. |
|
PR is ready for review |
trillium
left a comment
There was a problem hiding this comment.
Review: Approve
Summary: Adds comprehensive unit tests for Auth router covering all auth endpoints.
Tests (5/5 passing)
- ✅ POST /api/auth/signup
- ✅ POST /api/auth/signin
- ✅ POST /api/auth/verify-signin
- ✅ POST /api/auth/me
- ✅ POST /api/auth/logout
Notes
- Good middleware mocking (AuthUtil, verifyUser, verifyToken)
- Cookie handling properly tested
- Minor: console.log in mock (line 118) could be removed
Rebased onto upstream/development. Ready to merge.
c01d33f to
f260bd6
Compare
Fixes #1885
What changes did you make and why did you make them ?
auth.routerScreenshots of Passed Tests