oh so queerious - #1490
Open
ImShyMike wants to merge 10 commits into
Open
Conversation
Contributor
Greptile SummaryThis revision completes endpoint-specific OAuth scope enforcement and makes development OAuth seeding deterministic.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the prior scope-test and seed idempotency issues are addressed by explicit missing-scope cases, fixed-UID application lookup, exact development-token lookup, and unconditional scope reassignment. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as OAuth Client
participant API as Authenticated API
participant DK as Doorkeeper
participant User as User Data
Client->>API: Bearer access token
API->>DK: authorize required endpoint scope
alt Token invalid or expired
DK-->>Client: 401 Unauthorized
else Required scope missing
DK-->>Client: 403 Forbidden
else Scope granted
DK-->>API: Authorized resource owner
API->>User: Read permitted data
User-->>Client: 200 JSON response
end
Reviews (6): Last reviewed commit: "Fix seeding! (i am going insane)" | Re-trigger Greptile |
greptile what else do you want 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.