xds: apply ext_authz check deadline per-RPC - #13050
Merged
Merged
Conversation
withDeadlineAfter() resolves an absolute Deadline when it is called, so applying it to the shared AuthorizationStub at interceptor construction fixed one deadline for every RPC. Once the timeout elapsed, all later check RPCs failed immediately with DEADLINE_EXCEEDED. Apply the timeout to the per-RPC ExtAuthzClientCall instead.
kannanjgithub
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withDeadlineAfter()resolves the duration into an absoluteDeadlineat the moment it is called.ExtAuthzFilter.buildClientInterceptor()applied the configured ext_authz service timeout to the sharedAuthorizationStub, so a single deadline was fixed at filter initialization and reused by every RPC the interceptor handled.Once that timeout elapsed, every subsequent
check()was dispatched with an already-expired deadline and failed immediately withDEADLINE_EXCEEDED— failing all RPCs whenfailure_mode_allowis false, and skipping authorization entirely when it is true.The timeout is now applied on
ExtAuthzClientCall, which is constructed per RPC, so each check gets its own deadline.