Draft
xds: Fix Java 8 compilation failure; add ldsResourceNameResolver and forAddress() to XdsServerBuilder#12926
Conversation
|
…erverBuilder, add ldsResourceNameResolver support
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job tests (8)
xds: Fix Java 8 compilation failure; add ldsResourceNameResolver and forAddress() to XdsServerBuilder
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI "tests (8)" job failed because
XdsServerBuilder.forAddress()used Java 16+ pattern matching instanceof syntax, which is incompatible with the Java 8 build target.Changes
XdsServerBuilderforAddress(SocketAddress, ServerCredentials)static factoryldsResourceNameResolver(Function<String, String>)setter — allows callers to override how the LDS resource name is derived from the listening address, bypassingserver_listener_resource_name_templatein bootstrapXdsServerWrapperldsResourceNameResolverfieldldsResourceNameResolverthrough; existing callers passnull(no behavior change)internalStart(): whenldsResourceNameResolver != null, use it directly instead of computing the resource name from the bootstrap templateXdsServerWrapperTesttestLdsResourceNameResolver_overridesBootstrapTemplate()verifying the resolver takes precedence over the bootstrap template