Skip to content

xds: Fix Java 8 compilation failure; add ldsResourceNameResolver and forAddress() to XdsServerBuilder#12926

Draft
ran-su with Copilot wants to merge 3 commits into
masterfrom
copilot/fix-failing-github-actions-job
Draft

xds: Fix Java 8 compilation failure; add ldsResourceNameResolver and forAddress() to XdsServerBuilder#12926
ran-su with Copilot wants to merge 3 commits into
masterfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown

The CI "tests (8)" job failed because XdsServerBuilder.forAddress() used Java 16+ pattern matching instanceof syntax, which is incompatible with the Java 8 build target.

Changes

XdsServerBuilder

  • Fix: Replace pattern matching instanceof with Java 8 compatible explicit cast:
    // Before (Java 16+, breaks tests (8))
    if (address instanceof InetSocketAddress inetSocketAddress) {
      port = inetSocketAddress.getPort();
    }
    
    // After (Java 8 compatible)
    if (address instanceof InetSocketAddress) {
      port = ((InetSocketAddress) address).getPort();
    }
  • Add forAddress(SocketAddress, ServerCredentials) static factory
  • Add ldsResourceNameResolver(Function<String, String>) setter — allows callers to override how the LDS resource name is derived from the listening address, bypassing server_listener_resource_name_template in bootstrap

XdsServerWrapper

  • Add ldsResourceNameResolver field
  • Expand constructor overloads to thread ldsResourceNameResolver through; existing callers pass null (no behavior change)
  • In internalStart(): when ldsResourceNameResolver != null, use it directly instead of computing the resource name from the bootstrap template

XdsServerWrapperTest

  • Add testLdsResourceNameResolver_overridesBootstrapTemplate() verifying the resolver takes precedence over the bootstrap template

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 23, 2026

Copy link
Copy Markdown

CLA Not Signed

Copilot AI changed the title [WIP] Fix failing GitHub Actions job tests (8) xds: Fix Java 8 compilation failure; add ldsResourceNameResolver and forAddress() to XdsServerBuilder Jul 23, 2026
Copilot AI requested a review from ran-su July 23, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants