Open
Conversation
|
|
jeschkies
reviewed
Mar 25, 2026
| } | ||
| document, err := json.Marshal(record.Content) | ||
| if err != nil { | ||
| return logproto.Entry{}, err |
Collaborator
There was a problem hiding this comment.
Could you wrap the error?
| if val, ok := record.Content["eventTimestamp"]; ok { | ||
| sec, nsec, err := getUnixSecNsec(val.(string)) | ||
| if err != nil { | ||
| return logproto.Entry{}, err |
Collaborator
|
@rogelio-ramos, I'm sorry. I've missed to submit my comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for AWS Cognito Service Logs sent to S3.
For these logs (as with other "nested" JSON formats), processing now reads the content as a JSON stream and converts each record into a sendable entry, instead of treating it as lines of text.
When constructing each entry, the event's
eventTimestampfield is used to set the timestamp (and if it doesn't exist, it defaults to the current time), keeping the rest of the content as "raw" JSON in the log line.The S3 file pattern extracts account, region, Cognito pool, and event type.
Links about how to setup Cognito pool logs to S3: