chore: update go module path to github.com/gotify/server/v3 - #1030
Merged
Conversation
jmattheis
reviewed
Aug 16, 2026
|
|
||
| "github.com/gorilla/websocket" | ||
| "github.com/gotify/server/v2/model" | ||
| "github.com/gotify/server/v3/model" |
Member
There was a problem hiding this comment.
The plugin builds don't depend on gotify/server, why does the wrong module path block the plugin builds?
The build is failing because of formatting, otherwise this LGTM.
Member
Author
There was a problem hiding this comment.
Because it needs a phantom dependency to gotify/server/v3 to ensure it gets built with compatible dependencies. If the import path is wrong it wont be able to reference it.
eternal-flame-AD
force-pushed
the
go-imports
branch
from
August 16, 2026 09:01
1cc19ad to
5a36c8c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 74.78% 74.78%
=======================================
Files 66 66
Lines 3541 3541
=======================================
Hits 2648 2648
Misses 688 688
Partials 205 205 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bladeage
added a commit
to Bladeage/gotify-smtp
that referenced
this pull request
Aug 20, 2026
Reviewer feedback on the original change: gotify/server#1030 moved the server to github.com/gotify/server/v3, so the requirement this branch had dropped can come back. It cannot come back unconditionally, though -- that commit landed on master a month after v3.0.0 was tagged, so the released v3.0.0 still declares .../v2 while carrying a v3 tag. Neither path resolves for it: server/v3@v3.0.0 -> go.mod has non-.../v3 module path ".../v2" server/v2@v3.0.0 -> version "v3.0.0" invalid: should be v2, not v3 The module path is therefore read from the server's own go.mod instead of being derived from the tag name, and the requirement is only added when its major version matches. master and future releases get it; v3.0.0 does not, and the pinning below keeps that build aligned on its own. `go get` instead of `go mod edit -require`, because the default GOTIFY_VERSION is a branch name that has to be resolved to a pseudo-version first. Verified end to end for both paths: the plugin built with GOTIFY_VERSION=v3.0.0 loads in gotify/server:3.0.0, the one built with GOTIFY_VERSION=master loads in gotify/server:master (8af44e0). In both cases the resulting go.mod matches the server's for all 31 shared modules. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates go import paths to V3.
Sorry I missed this in the review. We need to update the go module path for any part of the V3 tree to be visible to the go toolchain. We would also have to bump the version once more to make plugins buildable again against v3.