fix: avoid unconditional use of window in policy creation logic#1234
Open
usefulthink wants to merge 2 commits into
Open
fix: avoid unconditional use of window in policy creation logic#1234usefulthink wants to merge 2 commits into
usefulthink wants to merge 2 commits into
Conversation
chrisjshull
requested changes
Jun 8, 2026
|
|
||
| // @jest-environment node | ||
| describe("setScriptSrc(): SSR safety", () => { | ||
| it("should be importable when window is not available", async () => { |
Contributor
There was a problem hiding this comment.
in case our infra changes over time, can you assert that window is not available for this test?
Contributor
Author
There was a problem hiding this comment.
you're right, added a check for this
| describe("setScriptSrc(): SSR safety", () => { | ||
| it("should be importable when window is not available", async () => { | ||
| await expect(import("./setScriptSrc.js")).resolves.toBeDefined(); | ||
| }); |
Contributor
There was a problem hiding this comment.
let's also get some coverage of what the expected output is, both for supported Trusted Types envs and unsupported envs?
Contributor
Author
There was a problem hiding this comment.
also added tests for the different new and old behaviors of setScriptSrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1233 🦕