fix: fixed GroundOverlay and added sample #826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the GroundOverlay Rendering Issue
Description
This PR fixes an issue where the GroundOverlay composable was added to the composition tree but failed to render on the map (#824).
Root Cause
The GroundOverlayPosition class was not a data class, meaning it lacked a value-based equals() implementation. In Compose, a new instance of GroundOverlayPosition was being created during recompositions. Because Compose couldn't identify these instances as equal, it triggered redundant updates to the underlying Google Maps SDK, leading to rendering instability that prevented the overlay from appearing
Changes
Core Fix: Converted GroundOverlayPosition to a data class in GroundOverlay.kt
.
API Enhancement: Added an update block for anchor in the GroundOverlay composable.
Sample App: Added GroundOverlayActivity.kt to demonstrate the fix and provide a "stress-test"
Verification Plan
Manual Verification
maps-app.Fixes #824