Skip to content

chore(librarian): update noxfile.py in generator-input#1167

Merged
parthea merged 2 commits intomainfrom
parthea-patch-2
Feb 13, 2026
Merged

chore(librarian): update noxfile.py in generator-input#1167
parthea merged 2 commits intomainfrom
parthea-patch-2

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Feb 13, 2026

This PR applies the patches from #1156 and #1163 to the generated noxfile.py under generator-input here : https://github.com/googleapis/python-firestore/blob/main/.librarian/generator-input/noxfile.py

@parthea parthea requested review from a team as code owners February 13, 2026 18:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Feb 13, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the noxfile.py in the generator-input directory. It adds a new dependency and removes support for Python 3.9, streamlining the testing environment.

Highlights

  • Dependency Update: Added 'google-cloud-testutils' to the list of dependencies.
  • Python Version Support: Removed support for Python 3.9 in the nox sessions.
Changelog
  • noxfile.py
    • Added google-cloud-testutils dependency.
    • Removed Python 3.9 from nox sessions.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the noxfile.py generator input by applying patches from other pull requests. The changes remove Python 3.9 from the default test sessions and introduce a formatting change. My review identifies an unnecessary blank line and an inconsistency in the removal of Python 3.9 support, which should be addressed for code quality and correctness.

I am having trouble creating individual review comments. Click here to see my feedback.

.librarian/generator-input/noxfile.py (70)

medium

This added blank line is unnecessary and should be removed to maintain code cleanliness.

.librarian/generator-input/noxfile.py (83-86)

medium

While unit-3.9 has been removed from the default nox.options.sessions, Python 3.9 is still present in the UNIT_TEST_PYTHON_VERSIONS list on line 45. To fully and consistently drop support for Python 3.9, it should also be removed from UNIT_TEST_PYTHON_VERSIONS.

@parthea parthea enabled auto-merge (squash) February 13, 2026 19:02
@parthea parthea disabled auto-merge February 13, 2026 19:09
@parthea parthea merged commit c68b296 into main Feb 13, 2026
23 of 28 checks passed
@parthea parthea deleted the parthea-patch-2 branch February 13, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments