Conversation
Replaces regular expression matching across hot RPC metrics pathways with direct string searching and delimiter-based parsing: - Extracts GFE and AFE Server-Timing latencies using delimiter checks and ASCII digit accumulation, avoiding per-RPC regex instantiation and string allocations. - Replaces named-capture regular expressions in resource name parsing with positional path segment inspection. - Replaces regex parsing in request ID operation extraction with a single-pass delimiter scan. - Updates latency checks in the interceptor and tracer to explicitly check for numeric types, ensuring 0 ms latencies are recorded accurately instead of misclassified as connectivity errors.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors metrics tracking and tracing in the Spanner client to eliminate regex allocations and improve performance. Specifically, it replaces regex-based parsing with manual string splitting and character-by-character parsing for extracting instance attributes, operation requests, and server-timing latencies (GFE and AFE). It also updates latency checks to explicitly verify number types, enabling support for zero-latency values, and adds comprehensive unit tests to validate these optimizations and edge cases. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces regular expression matching across hot RPC metrics pathways with direct string searching and delimiter-based parsing: