Conversation
MetricInterceptor previously defined pass-through requester hooks (sendMessage, halfClose, cancel) and used a 2-argument Listener interface. This caused @grpc/grpc-js to wrap every call in an InterceptingListenerImpl, adding a closure allocation and state machine bookkeeping for every streamed chunk. This change implements InterceptingListener directly and removes the redundant requester hooks. Because the listener methods now take a single argument, @grpc/grpc-js recognizes the listener as synchronous and forwards incoming streaming messages directly to downstream handlers.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the MetricInterceptor to use typed InterceptingListener from @grpc/grpc-js and removes redundant requester hooks, accompanied by new unit tests. The feedback identifies a potential ReferenceError in the new tests where Status.CANCELLED is referenced without being imported, and suggests using grpc.status.CANCELLED instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricInterceptor previously defined pass-through requester hooks (sendMessage, halfClose, cancel) and used a 2-argument Listener interface. This caused @grpc/grpc-js to wrap every call in an InterceptingListenerImpl, adding a closure allocation and state machine bookkeeping for every streamed chunk.
This change implements InterceptingListener directly and removes the redundant requester hooks. Because the listener methods now take a single argument, @grpc/grpc-js recognizes the listener as synchronous and forwards incoming streaming messages directly to downstream handlers.