chore(linter): ignore file changes in packages directory - #9302
shivanee-p wants to merge 3 commits into
Conversation
shivanee-p
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the linter configuration and script to ignore files inside top-level directories like packages/ and optimizes path segment checks by using Set lookups. Feedback on the changes highlights a bug where running the linter from a subdirectory causes incorrect path resolution; resolving file paths relative to the repository root instead of the current working directory is recommended to ensure correct behavior.
83cc487 to
29be9f8
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the linter script (bin/linter.mjs) and .eslintrc.json to support running from subdirectories by dynamically resolving the repository root path via Git. It also introduces a mechanism to ignore top-level directories like packages/ and optimizes ignored path checks using a Set. Feedback was provided to avoid hardcoding the path to the TypeScript compiler inside node_modules and instead resolve it dynamically using require.resolve for better robustness.
1 participant
Updates the monorepo linter to ignore changes in the top-level
packages/directory containing generated client librariesFixes b/560350445 🦕