Skip to content

refactor(ci): remove unused split-repository logic from release notes generator#13685

Open
jinseopkim0 wants to merge 4 commits into
mainfrom
jinseop/cleanup-split-repo-logic
Open

refactor(ci): remove unused split-repository logic from release notes generator#13685
jinseopkim0 wants to merge 4 commits into
mainfrom
jinseop/cleanup-split-repo-logic

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

Removes split-repository release notes parsing and URL linking logic from the BOM release notes compiler tool (ReleaseNoteGeneration.java).

Since all major Java client libraries (bigtable, firestore, pubsub, pubsublite) have been migrated into the monorepo, their release tags are hosted on googleapis/google-cloud-java and their old split repositories are no longer used for new releases. This change cleans up all associated dead code.

Verifications:

  • Completed local compilation, tests, and formatting successfully (ReleaseNoteGenerationTest passed).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the split-repository logic from the release note generation tool, simplifying the code to only support the monorepo. The review feedback points out that after these changes, some variables inside the loop in reportClientLibraryVersionDifference are now unused and can be removed. Additionally, the releaseUrl calculation can be hoisted out of the loop to avoid redundant calls and object allocations.

@jinseopkim0 jinseopkim0 force-pushed the jinseop/cleanup-split-repo-logic branch from f4d7e3b to b410b84 Compare July 7, 2026 19:06
@jinseopkim0

Copy link
Copy Markdown
Contributor Author

/gemini-review

@jinseopkim0

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the release note generation by removing support for split repositories, consolidating the release URL generation to use only the monorepo URL format, and cleaning up unused imports and methods. A review comment suggests using Guava's ImmutableList.Builder instead of a mutable ArrayList to build the list of release links for better performance and consistency with the codebase.

@jinseopkim0

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the release note generation process by removing support for split repositories (such as bigtable, firestore, pubsub, and pubsublite) and focusing solely on the monorepo. It removes unused imports, the splitRepositoryLibraryNames set, the releaseUrlForSplitRepo method, and refactors reportClientLibrariesNotableChangeLogs and releaseUrlForMonorepo to eliminate split repository logic. I have no feedback to provide.

@jinseopkim0 jinseopkim0 marked this pull request as ready for review July 7, 2026 21:12
@jinseopkim0 jinseopkim0 requested a review from a team as a code owner July 7, 2026 21:12
@jinseopkim0 jinseopkim0 requested a review from lqiu96 July 7, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants