feat(bigtable): add view_parameters support to BoundStatement#13673
Open
ad548 wants to merge 5 commits into
Open
feat(bigtable): add view_parameters support to BoundStatement#13673ad548 wants to merge 5 commits into
ad548 wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for view parameters in SQL BoundStatements, introducing the viewParameters field, builder methods to set them, and updating the proto serialization and test proxy deserializer. A review comment correctly points out that the newly added public method setViewParameter(String, Value) lacks direct unit test coverage and provides a helpful code suggestion to test this single-parameter setter.
…g view_parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the Java client changes supporting
view_parametersinExecuteQueryRequest(originally developed and reviewed internally in CL 13080 / branchadd-view-parameters-support).Changes
view_parameterssupport toBoundStatementand its builder.BoundStatementTestwith unit tests forview_parameters.BoundStatementDeserializerin test-proxy to handleview_parameters.Verification
ExecuteQueryRequestin generated GAPIC proto library already containsview_parameterssupport.google-cloud-bigtableand dependencies.