feat(gapic-generator): Add NullMarked annotation to generated classes#13584
feat(gapic-generator): Add NullMarked annotation to generated classes#13584nnicolee wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the org.jspecify:jspecify dependency to multiple pom.xml files across various Google Cloud Java proto modules. However, in the java-bigtable modules, the dependency was incorrectly placed inside the <dependencyManagement> block instead of the <dependencies> block. Additionally, since these pom.xml files are auto-generated, manual edits should be avoided to prevent them from being overwritten; instead, the generator or source metadata should be updated.
7ae01f1 to
6383dc7
Compare
|
|
25f9d8c to
be44402
Compare
be44402 to
c7a5ee4
Compare
lqiu96
left a comment
There was a problem hiding this comment.
Thanks! The PR looks good to me, but you can make sure that this PR isn't merged until after the release goes out?
|
hold off on merging for a bit |





This PR updates the gapic-generator-java to add the JSpecify @NullMarked annotation to all generated class declarations. Adding @NullMarked at the class level defines the class scope as null-safe, establishing that all unannotated types in method signatures (parameters and return types) are nonnull able by default. This is the first phase in onboarding the generated client libraries to compile-time safety validation, see design doc for more details: go/sdk:java-jspecify-null-annotations-gapic
Classes Annotated:
Implementation Changes:
Verification/Testing:
Revisions:
Next Steps: